Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2269143003: cc : Add OnTransformAnimated to transform tree (Closed)

Created:
4 years, 4 months ago by jaydasika
Modified:
4 years, 4 months ago
Reviewers:
chrishtr, weiliangc, ajuma
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, sunxd
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc : Add OnTransformAnimated to transform tree And use it to update transform animations directly instead of routing the updates through layers. This CL also changes element_layers_maps to hold layer_id instead of layer so that we can get the property tree index for animation update without accessing LayerImpl BUG=638297 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/09e1613788e00d4fef7bd76ddcb4ed592b9a347d Cr-Commit-Position: refs/heads/master@{#414153}

Patch Set 1 #

Total comments: 5

Patch Set 2 : comments #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -66 lines) Patch
M cc/layers/layer_impl.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M cc/layers/layer_impl.cc View 1 2 2 chunks +0 lines, -35 lines 0 comments Download
M cc/layers/layer_impl_unittest.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M cc/trees/damage_tracker_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 2 3 chunks +16 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 2 chunks +14 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 4 chunks +10 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_picture.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M cc/trees/property_tree.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/trees/property_tree.cc View 1 3 chunks +17 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/CompositorMutableState.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 31 (19 generated)
jaydasika
PTAL https://codereview.chromium.org/2269143003/diff/1/cc/trees/layer_tree_host_impl.cc File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/2269143003/diff/1/cc/trees/layer_tree_host_impl.cc#newcode3952 cc/trees/layer_tree_host_impl.cc:3952: layer->set_was_ever_ready_since_last_transform_animation(false); Will sort out was_ever_ready_since_last_transform_animation in a different ...
4 years, 4 months ago (2016-08-23 21:53:02 UTC) #5
ajuma
lgtm https://codereview.chromium.org/2269143003/diff/1/cc/trees/layer_tree_impl.cc File cc/trees/layer_tree_impl.cc (right): https://codereview.chromium.org/2269143003/diff/1/cc/trees/layer_tree_impl.cc#newcode519 cc/trees/layer_tree_impl.cc:519: LayerImpl* LayerTreeImpl::LayerByElementId(ElementId element_id) const { Just to make ...
4 years, 4 months ago (2016-08-23 23:40:12 UTC) #6
jaydasika
https://codereview.chromium.org/2269143003/diff/1/cc/trees/layer_tree_impl.cc File cc/trees/layer_tree_impl.cc (right): https://codereview.chromium.org/2269143003/diff/1/cc/trees/layer_tree_impl.cc#newcode519 cc/trees/layer_tree_impl.cc:519: LayerImpl* LayerTreeImpl::LayerByElementId(ElementId element_id) const { On 2016/08/23 23:40:12, ajuma ...
4 years, 4 months ago (2016-08-24 00:13:43 UTC) #9
jaydasika
chrishtr: Can you review changes in platform/graphics ?
4 years, 4 months ago (2016-08-24 00:14:30 UTC) #11
chrishtr
lgtm
4 years, 4 months ago (2016-08-24 00:19:40 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269143003/20001
4 years, 4 months ago (2016-08-24 03:05:19 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/244568)
4 years, 4 months ago (2016-08-24 03:11:24 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269143003/40001
4 years, 4 months ago (2016-08-24 17:26:46 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/280150)
4 years, 4 months ago (2016-08-24 19:14:05 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269143003/40001
4 years, 4 months ago (2016-08-24 19:18:30 UTC) #28
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-24 21:40:07 UTC) #29
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 21:42:08 UTC) #31
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/09e1613788e00d4fef7bd76ddcb4ed592b9a347d
Cr-Commit-Position: refs/heads/master@{#414153}

Powered by Google App Engine
This is Rietveld 408576698