Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2269133002: Add fuzzer_test_support.cc to net_fuzzer_test_support target (Closed)

Created:
4 years, 4 months ago by Charlie Harrison
Modified:
4 years, 4 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add fuzzer_test_support.cc to net_fuzzer_test_support target This was broken by https://codereview.chromium.org/2250263003/, which deleted the fuzzer_test_support cc file from the source set. BUG=628503 Committed: https://crrev.com/37ef985f4359f4b5b4b26489b5880d0025a61772 Cr-Commit-Position: refs/heads/master@{#413801}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M net/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Charlie Harrison
PTAL? Let me know if I'm off base here and there's a better solution.
4 years, 4 months ago (2016-08-23 16:42:39 UTC) #4
mmenke
On 2016/08/23 16:42:39, Charlie Harrison wrote: > PTAL? Let me know if I'm off base ...
4 years, 4 months ago (2016-08-23 18:13:29 UTC) #5
Charlie Harrison
Done. Thanks and sorry for breaking things :P
4 years, 4 months ago (2016-08-23 18:15:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269133002/1
4 years, 4 months ago (2016-08-23 18:15:30 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 19:00:37 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 19:04:50 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37ef985f4359f4b5b4b26489b5880d0025a61772
Cr-Commit-Position: refs/heads/master@{#413801}

Powered by Google App Engine
This is Rietveld 408576698