Allow overlapping sync and async startup requests

content/browser/browser_main_runner.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/browser/browser_main_runner.h"
 
 #include "base/allocator/allocator_shim.h"
 #include "base/base_switches.h"
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
@@ skipping 12 matching lines @@
 #include "base/win/windows_version.h"
 #include "ui/base/win/scoped_ole_initializer.h"
 #endif
 
 bool g_exited_main_message_loop = false;
 
 namespace content {
 
 class BrowserMainRunnerImpl : public BrowserMainRunner {
  public:
-  BrowserMainRunnerImpl() : is_initialized_(false), is_shutdown_(false) {}
+  BrowserMainRunnerImpl()
+      : initialization_started_(false), is_shutdown_(false) {}
 
   virtual ~BrowserMainRunnerImpl() {
-    if (is_initialized_ && !is_shutdown_)
+    if (initialization_started_ && !is_shutdown_)
       Shutdown();
   }
 
-  virtual int Initialize(const MainFunctionParams& parameters)
-      OVERRIDE {
-    TRACE_EVENT0("startup", "BrowserMainRunnerImpl::Initialize")
-    is_initialized_ = true;
+  virtual int Initialize(const MainFunctionParams& parameters) OVERRIDE {
+    TRACE_EVENT0("startup", "BrowserMainRunnerImpl::Initialize");
+    // On Android we normally initialize the browser in a series of UI thread
+    // tasks. While this is happening a second request can come from the OS or
+    // another application to start the browser. If this happens then we must
+    // not run these parts of initialization twice.
+    if (!initialization_started_) {
+      initialization_started_ = true;
 
 #if !defined(OS_IOS)
-  if (parameters.command_line.HasSwitch(switches::kWaitForDebugger))
-    base::debug::WaitForDebugger(60, true);
+      if (parameters.command_line.HasSwitch(switches::kWaitForDebugger))
+        base::debug::WaitForDebugger(60, true);
 #endif
 
 #if defined(OS_WIN)
-    if (parameters.command_line.HasSwitch(
-            switches::kEnableTextServicesFramework)) {
-      base::win::SetForceToUseTSF();
-    } else if (base::win::GetVersion() < base::win::VERSION_VISTA) {
-      // When "Extend support of advanced text services to all programs"
-      // (a.k.a. Cicero Unaware Application Support; CUAS) is enabled on
-      // Windows XP and handwriting modules shipped with Office 2003 are
-      // installed, "penjpn.dll" and "skchui.dll" will be loaded and then crash
-      // unless a user installs Office 2003 SP3. To prevent these modules from
-      // being loaded, disable TSF entirely. crbug/160914.
-      // TODO(yukawa): Add a high-level wrapper for this instead of calling
-      // Win32 API here directly.
-      ImmDisableTextFrameService(static_cast<DWORD>(-1));
-    }
+      if (parameters.command_line.HasSwitch(
+              switches::kEnableTextServicesFramework)) {
+        base::win::SetForceToUseTSF();
+      } else if (base::win::GetVersion() < base::win::VERSION_VISTA) {
+        // When "Extend support of advanced text services to all programs"
+        // (a.k.a. Cicero Unaware Application Support; CUAS) is enabled on
+        // Windows XP and handwriting modules shipped with Office 2003 are
+        // installed, "penjpn.dll" and "skchui.dll" will be loaded and then
+        // crash
+        // unless a user installs Office 2003 SP3. To prevent these modules from
+        // being loaded, disable TSF entirely. crbug/160914.
+        // TODO(yukawa): Add a high-level wrapper for this instead of calling
+        // Win32 API here directly.
+        ImmDisableTextFrameService(static_cast<DWORD>(-1));
+      }
 #endif  // OS_WIN
 
-    base::StatisticsRecorder::Initialize();
+      base::StatisticsRecorder::Initialize();
 
-    notification_service_.reset(new NotificationServiceImpl);
+      notification_service_.reset(new NotificationServiceImpl);
 
 #if defined(OS_WIN)
-    // Ole must be initialized before starting message pump, so that TSF
-    // (Text Services Framework) module can interact with the message pump
-    // on Windows 8 Metro mode.
-    ole_initializer_.reset(new ui::ScopedOleInitializer);
+      // Ole must be initialized before starting message pump, so that TSF
+      // (Text Services Framework) module can interact with the message pump
+      // on Windows 8 Metro mode.
+      ole_initializer_.reset(new ui::ScopedOleInitializer);
 #endif  // OS_WIN
 
-    main_loop_.reset(new BrowserMainLoop(parameters));
+      main_loop_.reset(new BrowserMainLoop(parameters));
 
-    main_loop_->Init();
+      main_loop_->Init();
 
-    main_loop_->EarlyInitialization();
+      main_loop_->EarlyInitialization();
 
-    // Must happen before we try to use a message loop or display any UI.
-    main_loop_->InitializeToolkit();
+      // Must happen before we try to use a message loop or display any UI.
+      main_loop_->InitializeToolkit();
 
-    main_loop_->MainMessageLoopStart();
+      main_loop_->MainMessageLoopStart();
 
-    // WARNING: If we get a WM_ENDSESSION, objects created on the stack here
-    // are NOT deleted. If you need something to run during WM_ENDSESSION add it
-    // to browser_shutdown::Shutdown or BrowserProcess::EndSession.
+// WARNING: If we get a WM_ENDSESSION, objects created on the stack here
+// are NOT deleted. If you need something to run during WM_ENDSESSION add it
+// to browser_shutdown::Shutdown or BrowserProcess::EndSession.
 
 #if defined(OS_WIN) && !defined(NO_TCMALLOC)
-    // When linking shared libraries, NO_TCMALLOC is defined, and dynamic
-    // allocator selection is not supported.
+      // When linking shared libraries, NO_TCMALLOC is defined, and dynamic
+      // allocator selection is not supported.
 
-    // Make this call before going multithreaded, or spawning any subprocesses.
-    base::allocator::SetupSubprocessAllocator();
+      // Make this call before going multithreaded, or spawning any
+      // subprocesses.
+      base::allocator::SetupSubprocessAllocator();
 #endif
-    ui::InitializeInputMethod();
-
+      ui::InitializeInputMethod();
+    }
     main_loop_->CreateStartupTasks();
     int result_code = main_loop_->GetResultCode();
     if (result_code > 0)
       return result_code;
 
 #if defined(OS_WIN)
     // The process should crash when going through abnormal termination.
     // Make sure this is done only when Shutdown() will be called.
     base::win::SetShouldCrashOnProcessDetach(true);
     base::win::SetAbortBehaviorForCrashReporting();
 #endif
 
     // Return -1 to indicate no early termination.
     return -1;
   }
 
   virtual int Run() OVERRIDE {
-    DCHECK(is_initialized_);
+    DCHECK(initialization_started_);
     DCHECK(!is_shutdown_);
     main_loop_->RunMainMessageLoopParts();
     return main_loop_->GetResultCode();
   }
 
   virtual void Shutdown() OVERRIDE {
-    DCHECK(is_initialized_);
+    DCHECK(initialization_started_);
     DCHECK(!is_shutdown_);
     g_exited_main_message_loop = true;
 
     main_loop_->ShutdownThreadsAndCleanUp();
 
     ui::ShutdownInputMethod();
 #if defined(OS_WIN)
     ole_initializer_.reset(NULL);
 #endif
 
     main_loop_.reset(NULL);
 
     notification_service_.reset(NULL);
 
 #if defined(OS_WIN)
     base::win::SetShouldCrashOnProcessDetach(false);
 #endif
 
     is_shutdown_ = true;
   }
 
  protected:
   // True if the runner has been initialized.

[Yaron, 2013/08/22 06:00:26]

Nit: update

[aberent, 2013/08/23 11:40:21]

Done.

-  bool is_initialized_;
+  bool initialization_started_;
 
   // True if the runner has been shut down.
   bool is_shutdown_;
 
   scoped_ptr<NotificationServiceImpl> notification_service_;
   scoped_ptr<BrowserMainLoop> main_loop_;
 #if defined(OS_WIN)
   scoped_ptr<ui::ScopedOleInitializer> ole_initializer_;
 #endif
 
   DISALLOW_COPY_AND_ASSIGN(BrowserMainRunnerImpl);
 };
 
 // static
 BrowserMainRunner* BrowserMainRunner::Create() {
   return new BrowserMainRunnerImpl();
 }
 
 }  // namespace content