Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 2269073002: Revert of Resolving drawImage issue with canvases that contain bitmap images (Closed)

Created:
4 years, 4 months ago by xidachen
Modified:
4 years, 4 months ago
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Resolving drawImage issue with canvases that contain bitmap images (patchset #3 id:60001 of https://codereview.chromium.org/2267653005/ ) Reason for revert: Causing this DCHECK: m_context->getContextType() != CanvasRenderingContext::ContextImageBitmap on this test: transferFromImageBitmap-drawImage.html Original issue's description: > Adding proper check for canvas type to > HTMLCanvasElement::getSourceImageForCanvas() such that > drawImage can correctly draw canvases with bitmap images. > > BUG=639841 > > Committed: https://crrev.com/4d29ebec048d83aac139ec5edcbe22d107351b7b > Cr-Commit-Position: refs/heads/master@{#413731} TBR=junov@chromium.org,zakerinasab@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=639841 Committed: https://crrev.com/061450ece090f8f8ad550cbe470dec03fbe5b487 Cr-Commit-Position: refs/heads/master@{#413737}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -51 lines) Patch
D third_party/WebKit/LayoutTests/fast/canvas/imagebitmap/transferFromImageBitmap-drawImage.html View 1 chunk +0 lines, -39 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 1 chunk +3 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
xidachen
Created Revert of Resolving drawImage issue with canvases that contain bitmap images
4 years, 4 months ago (2016-08-23 14:53:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269073002/1
4 years, 4 months ago (2016-08-23 14:53:33 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 14:54:20 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 14:55:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/061450ece090f8f8ad550cbe470dec03fbe5b487
Cr-Commit-Position: refs/heads/master@{#413737}

Powered by Google App Engine
This is Rietveld 408576698