Revert of Explicitly ask for stack frame pointers on Debug posix builds.

Revert of Explicitly ask for stack frame pointers on Debug posix builds. (patchset #1 id:1 of https://codereview.chromium.org/2266073002/ )

Reason for revert:
This broke all Android x86/x64 debug bots, for example:

https://build.chromium.org/p/chromium.android/builders/Android%20x86%20Builder%20%28dbg%29/builds/7886
https://build.chromium.org/p/chromium.android/builders/Android%20x64%20Builder%20%28dbg%29/builds/7915

It broke because ffmpeg expects to be compiled with -fomit-frame-pointer so that files like third_party/ffmpeg/libavcodec/x86/mpegaudiodsp.c:86 can use an extra register; globally applying -fno-omit-frame-pointer appears to have caused it to run out of registers.

If you look at third_party/ffmpeg/ffmpeg.gyp:260, you'll see it removes this flag if it has been set globally:

'cflags!': [
  '-fno-omit-frame-pointer',
],

But the GN equivalent third_party/ffmpeg/BUILD.gn can't do this, because it's an error in GN to remove a flag that hasn't been set. A clean solution is probably to create a new config in build/config/compiler/BUILD.gn providing the default no-omit-frame-pointer cflag, that is always included, then third_party/ffmpeg/BUILD.gn can unconditionally remove that config and set its own omit-frame-pointer cflag.

Original issue's description:
> Explicitly ask for stack frame pointers on Debug posix builds.
>
> GCC / LLVM can omit stack frames at any optimization level.  We use -Os
> for Android Debug, and -O3 for targets like v8.  This can cause the runtime
> stack unwinding debug feature of 'tcmalloc' to mis-unwind and crash.
>
> R=brettw@chromium.org
> R=dpranke@chromium.org
> BUG=636489
>
> Committed: https://crrev.com/4e69ee6824fc94c59762b5f05f9f340fb4466d7f
> Cr-Commit-Position: refs/heads/master@{#413628}

TBR=brettw@chromium.org,dpranke@chromium.org,kbr@chromium.org,vmiura@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=636489
Committed: https://crrev.com/8021d966e853806efec25188e320e45e0bc0bc8b
Cr-Commit-Position: refs/heads/master@{#413722}

[johnme, 2016-08-23 13:38:44]

The CQ bit was checked by johnme@chromium.org

[johnme, 2016-08-23 13:38:44]

Created Revert of Explicitly ask for stack frame pointers on Debug posix builds.

[commit-bot: I haz the power, 2016-08-23 13:38:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 13:39:36]

Description was changed from

==========
Revert of Explicitly ask for stack frame pointers on Debug posix builds.
(patchset #1 id:1 of https://codereview.chromium.org/2266073002/ )

Reason for revert:
This broke all Android x86/x64 debug bots, for example:

https://build.chromium.org/p/chromium.android/builders/Android%20x86%20Builde...
https://build.chromium.org/p/chromium.android/builders/Android%20x64%20Builde...

It broke because ffmpeg expects to be compiled with -fomit-frame-pointer so that
files like third_party/ffmpeg/libavcodec/x86/mpegaudiodsp.c:86 can use an extra
register; globally applying -fno-omit-frame-pointer appears to have caused it to
run out of registers.

If you look at third_party/ffmpeg/ffmpeg.gyp:260, you'll see it removes this
flag if it has been set globally:

'cflags!': [
  '-fno-omit-frame-pointer',
],

But the GN equivalent third_party/ffmpeg/BUILD.gn can't do this, because it's an
error in GN to remove a flag that hasn't been set. A clean solution is probably
to create a new config in build/config/compiler/BUILD.gn providing the default
no-omit-frame-pointer cflag, that is always included, then
third_party/ffmpeg/BUILD.gn can unconditionally remove that config and set its
own omit-frame-pointer cflag.

Original issue's description:
> Explicitly ask for stack frame pointers on Debug posix builds.
> 
> GCC / LLVM can omit stack frames at any optimization level.  We use -Os
> for Android Debug, and -O3 for targets like v8.  This can cause the runtime
> stack unwinding debug feature of 'tcmalloc' to mis-unwind and crash.
> 
> R=brettw@chromium.org
> R=dpranke@chromium.org
> BUG=636489
> 
> Committed: https://crrev.com/4e69ee6824fc94c59762b5f05f9f340fb4466d7f
> Cr-Commit-Position: refs/heads/master@{#413628}

TBR=brettw@chromium.org,dpranke@chromium.org,kbr@chromium.org,vmiura@chromium...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=636489
==========

to

==========
Revert of Explicitly ask for stack frame pointers on Debug posix builds.
(patchset #1 id:1 of https://codereview.chromium.org/2266073002/ )

Reason for revert:
This broke all Android x86/x64 debug bots, for example:

https://build.chromium.org/p/chromium.android/builders/Android%20x86%20Builde...
https://build.chromium.org/p/chromium.android/builders/Android%20x64%20Builde...

It broke because ffmpeg expects to be compiled with -fomit-frame-pointer so that
files like third_party/ffmpeg/libavcodec/x86/mpegaudiodsp.c:86 can use an extra
register; globally applying -fno-omit-frame-pointer appears to have caused it to
run out of registers.

If you look at third_party/ffmpeg/ffmpeg.gyp:260, you'll see it removes this
flag if it has been set globally:

'cflags!': [
  '-fno-omit-frame-pointer',
],

But the GN equivalent third_party/ffmpeg/BUILD.gn can't do this, because it's an
error in GN to remove a flag that hasn't been set. A clean solution is probably
to create a new config in build/config/compiler/BUILD.gn providing the default
no-omit-frame-pointer cflag, that is always included, then
third_party/ffmpeg/BUILD.gn can unconditionally remove that config and set its
own omit-frame-pointer cflag.

Original issue's description:
> Explicitly ask for stack frame pointers on Debug posix builds.
> 
> GCC / LLVM can omit stack frames at any optimization level.  We use -Os
> for Android Debug, and -O3 for targets like v8.  This can cause the runtime
> stack unwinding debug feature of 'tcmalloc' to mis-unwind and crash.
> 
> R=brettw@chromium.org
> R=dpranke@chromium.org
> BUG=636489
> 
> Committed: https://crrev.com/4e69ee6824fc94c59762b5f05f9f340fb4466d7f
> Cr-Commit-Position: refs/heads/master@{#413628}

TBR=brettw@chromium.org,dpranke@chromium.org,kbr@chromium.org,vmiura@chromium...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=636489
==========

[commit-bot: I haz the power, 2016-08-23 13:39:40]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-23 13:42:25]

Description was changed from

==========
Revert of Explicitly ask for stack frame pointers on Debug posix builds.
(patchset #1 id:1 of https://codereview.chromium.org/2266073002/ )

Reason for revert:
This broke all Android x86/x64 debug bots, for example:

https://build.chromium.org/p/chromium.android/builders/Android%20x86%20Builde...
https://build.chromium.org/p/chromium.android/builders/Android%20x64%20Builde...

It broke because ffmpeg expects to be compiled with -fomit-frame-pointer so that
files like third_party/ffmpeg/libavcodec/x86/mpegaudiodsp.c:86 can use an extra
register; globally applying -fno-omit-frame-pointer appears to have caused it to
run out of registers.

If you look at third_party/ffmpeg/ffmpeg.gyp:260, you'll see it removes this
flag if it has been set globally:

'cflags!': [
  '-fno-omit-frame-pointer',
],

But the GN equivalent third_party/ffmpeg/BUILD.gn can't do this, because it's an
error in GN to remove a flag that hasn't been set. A clean solution is probably
to create a new config in build/config/compiler/BUILD.gn providing the default
no-omit-frame-pointer cflag, that is always included, then
third_party/ffmpeg/BUILD.gn can unconditionally remove that config and set its
own omit-frame-pointer cflag.

Original issue's description:
> Explicitly ask for stack frame pointers on Debug posix builds.
> 
> GCC / LLVM can omit stack frames at any optimization level.  We use -Os
> for Android Debug, and -O3 for targets like v8.  This can cause the runtime
> stack unwinding debug feature of 'tcmalloc' to mis-unwind and crash.
> 
> R=brettw@chromium.org
> R=dpranke@chromium.org
> BUG=636489
> 
> Committed: https://crrev.com/4e69ee6824fc94c59762b5f05f9f340fb4466d7f
> Cr-Commit-Position: refs/heads/master@{#413628}

TBR=brettw@chromium.org,dpranke@chromium.org,kbr@chromium.org,vmiura@chromium...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=636489
==========

to

==========
Revert of Explicitly ask for stack frame pointers on Debug posix builds.
(patchset #1 id:1 of https://codereview.chromium.org/2266073002/ )

Reason for revert:
This broke all Android x86/x64 debug bots, for example:

https://build.chromium.org/p/chromium.android/builders/Android%20x86%20Builde...
https://build.chromium.org/p/chromium.android/builders/Android%20x64%20Builde...

It broke because ffmpeg expects to be compiled with -fomit-frame-pointer so that
files like third_party/ffmpeg/libavcodec/x86/mpegaudiodsp.c:86 can use an extra
register; globally applying -fno-omit-frame-pointer appears to have caused it to
run out of registers.

If you look at third_party/ffmpeg/ffmpeg.gyp:260, you'll see it removes this
flag if it has been set globally:

'cflags!': [
  '-fno-omit-frame-pointer',
],

But the GN equivalent third_party/ffmpeg/BUILD.gn can't do this, because it's an
error in GN to remove a flag that hasn't been set. A clean solution is probably
to create a new config in build/config/compiler/BUILD.gn providing the default
no-omit-frame-pointer cflag, that is always included, then
third_party/ffmpeg/BUILD.gn can unconditionally remove that config and set its
own omit-frame-pointer cflag.

Original issue's description:
> Explicitly ask for stack frame pointers on Debug posix builds.
>
> GCC / LLVM can omit stack frames at any optimization level.  We use -Os
> for Android Debug, and -O3 for targets like v8.  This can cause the runtime
> stack unwinding debug feature of 'tcmalloc' to mis-unwind and crash.
>
> R=brettw@chromium.org
> R=dpranke@chromium.org
> BUG=636489
>
> Committed: https://crrev.com/4e69ee6824fc94c59762b5f05f9f340fb4466d7f
> Cr-Commit-Position: refs/heads/master@{#413628}

TBR=brettw@chromium.org,dpranke@chromium.org,kbr@chromium.org,vmiura@chromium...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=636489

Committed: https://crrev.com/8021d966e853806efec25188e320e45e0bc0bc8b
Cr-Commit-Position: refs/heads/master@{#413722}
==========

[commit-bot: I haz the power, 2016-08-23 13:42:26]

Patchset 1 (id:??) landed as
https://crrev.com/8021d966e853806efec25188e320e45e0bc0bc8b
Cr-Commit-Position: refs/heads/master@{#413722}

[Dirk Pranke, 2016-08-23 15:19:54]

lgtm