third_party/WebKit/LayoutTests/fast/forms/text/text-set-selection-crash.html - Issue 2269043002: Reland of Remove EventSender from HTMLStyleElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/forms/text/text-set-selection-crash.html

Issue 2269043002: Reland of Remove EventSender from HTMLStyleElement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Deflake Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/inert-node-is-unfocusable-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/forms/text/text-set-selection-crash-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/forms/text/text-set-selection-crash.html

diff --git a/third_party/WebKit/LayoutTests/fast/forms/text/text-set-selection-crash.html b/third_party/WebKit/LayoutTests/fast/forms/text/text-set-selection-crash.html

index c0983369e44453a2e6fcded76b4b57b49a9a6cc9..d9ec4c39c3664d8e2f67e0917753f38cfb499aec 100644

--- a/third_party/WebKit/LayoutTests/fast/forms/text/text-set-selection-crash.html

+++ b/third_party/WebKit/LayoutTests/fast/forms/text/text-set-selection-crash.html

@@ -1,13 +1,14 @@

<body>

-<script src="../../../resources/js-test.js"></script>

+<script src="../../../resources/testharness.js"></script>

+<script src="../../../resources/testharnessreport.js"></script>

-description('There was a bug that HTMLTextFormControlElement::setSelectionRange crashed. This test requires ASAN or something.');

-jsTestIsAsync = true;

+var t = async_test('There was a bug that HTMLTextFormControlElement::setSelectionRange crashed. This test requires ASAN or something.');

document.body.onload = function() {

- document.getElementsByTagName('input')[0].focus();

- testPassed('if not crash.');

- finishJSTest();

+ t.step(function() {

yhirano 2016/11/08 06:25:54 Can you tell me why this |t.step| is needed?

hiroshige 2016/11/08 06:38:37 Removing t.step() also works.

+ document.getElementsByTagName('input')[0].focus();

+ }, 'passed if not crash.');

+ t.done();

};

</script>

</body>