Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 226903002: tests/html: removed usage of deprecated unittest features (Closed)

Created:
6 years, 8 months ago by kevmoo
Modified:
6 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

tests/html: removed usage of deprecated unittest features R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=34755

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -71 lines) Patch
M tests/html/canvas_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M tests/html/canvasrenderingcontext2d_test.dart View 7 chunks +7 lines, -21 lines 0 comments Download
M tests/html/dromaeo_smoke_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/form_data_test.dart View 2 chunks +1 line, -7 lines 0 comments Download
M tests/html/html.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/html/isolates_test.dart View 1 chunk +4 lines, -8 lines 0 comments Download
M tests/html/js_interop_1_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/mutationobserver_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/postmessage_structured_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/html/url_test.dart View 2 chunks +2 lines, -6 lines 0 comments Download
M tests/html/websql_test.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M tests/html/xhr_cross_origin_test.dart View 1 chunk +3 lines, -5 lines 0 comments Download
M tests/html/xhr_test.dart View 3 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kevmoo
Also improved usage of unittest a bit
6 years, 8 months ago (2014-04-04 23:52:25 UTC) #1
Siggi Cherem (dart-lang)
lgtm
6 years, 8 months ago (2014-04-05 00:59:36 UTC) #2
kevmoo
6 years, 8 months ago (2014-04-05 01:01:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r34755 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698