Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 2269003002: Show the app title when the window title is empty for ARC apps (Closed)

Created:
4 years, 4 months ago by yoshiki
Modified:
4 years, 3 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show the app title when the window title is empty for ARC apps BUG=640080 Committed: https://crrev.com/4fe27f6f22ff375e0885f0e693e68c5f548f1154 Cr-Commit-Position: refs/heads/master@{#414711}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.cc View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
yoshiki
Oshima-san, PTAL. Thanks.
4 years, 3 months ago (2016-08-26 01:54:12 UTC) #6
oshima
lgtm
4 years, 3 months ago (2016-08-26 13:41:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269003002/20001
4 years, 3 months ago (2016-08-26 14:49:03 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-08-26 14:52:43 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 14:54:03 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4fe27f6f22ff375e0885f0e693e68c5f548f1154
Cr-Commit-Position: refs/heads/master@{#414711}

Powered by Google App Engine
This is Rietveld 408576698