Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2268993002: FreeBSD: Fix semaphore alignment (Closed)

Created:
4 years, 4 months ago by targos
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

FreeBSD: Fix semaphore alignment On FreeBSD, sem_t is a struct with a couple of uint32_t fields. It only needs dword alignment on 64 bits architectures, not the qword (pointer) alignment that the CHECK currently enforces. BUG= Committed: https://crrev.com/6993943e10adc68401ed3b1014464f913cc66237 Cr-Commit-Position: refs/heads/master@{#38829}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/base/platform/semaphore.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
targos
4 years, 4 months ago (2016-08-23 07:50:37 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 4 months ago (2016-08-23 12:45:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268993002/1
4 years, 4 months ago (2016-08-23 14:01:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 14:23:53 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 14:24:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6993943e10adc68401ed3b1014464f913cc66237
Cr-Commit-Position: refs/heads/master@{#38829}

Powered by Google App Engine
This is Rietveld 408576698