Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: src/compiler-dispatcher/compiler-dispatcher-job.h

Issue 2268983002: Finalizing parsing in a compile job should immediately report errors (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler-dispatcher/compiler-dispatcher-job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler-dispatcher/compiler-dispatcher-job.h
diff --git a/src/compiler-dispatcher/compiler-dispatcher-job.h b/src/compiler-dispatcher/compiler-dispatcher-job.h
index 92127ff6c632bd86c20bebf574a06817349fba14..50414af63948f6af96b6d9f74a8fcfb1b858b988 100644
--- a/src/compiler-dispatcher/compiler-dispatcher-job.h
+++ b/src/compiler-dispatcher/compiler-dispatcher-job.h
@@ -50,11 +50,9 @@ class CompilerDispatcherJob {
// Transition from kReadyToParse to kParsed.
void Parse();
- // Transition from kParsed to kReadyToCompile (or kFailed).
- void FinalizeParsingOnMainThread();
-
- // Transition from kFailed to kDone.
- void ReportErrorsOnMainThread();
+ // Transition from kParsed to kReadyToCompile (or kFailed). Returns false
+ // when transitioning to kFailed. In that case, an exception is pending.
+ bool FinalizeParsingOnMainThread();
// Transition from any state to kInitial and free all resources.
void ResetOnMainThread();
@@ -62,8 +60,6 @@ class CompilerDispatcherJob {
private:
FRIEND_TEST(CompilerDispatcherJobTest, ScopeChain);
- void InternalizeParsingResult();
-
CompileJobStatus status_ = CompileJobStatus::kInitial;
Isolate* isolate_;
Handle<JSFunction> function_; // Global handle.
@@ -76,6 +72,7 @@ class CompilerDispatcherJob {
std::unique_ptr<Utf16CharacterStream> character_stream_;
std::unique_ptr<ParseInfo> parse_info_;
std::unique_ptr<Parser> parser_;
+ std::unique_ptr<DeferredHandles> handles_from_parsing_;
bool can_parse_on_background_thread_;
« no previous file with comments | « no previous file | src/compiler-dispatcher/compiler-dispatcher-job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698