Finalizing parsing in a compile job should immediately report errors

test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 
 #include "include/v8.h"
 #include "src/api.h"
 #include "src/ast/scopes.h"
 #include "src/compiler-dispatcher/compiler-dispatcher-job.h"
@@ skipping 74 matching lines @@
 
 TEST_F(CompilerDispatcherJobTest, StateTransitions) {
   std::unique_ptr<CompilerDispatcherJob> job(new CompilerDispatcherJob(
       i_isolate(), CreateFunction(i_isolate(), nullptr), FLAG_stack_size));
 
   ASSERT_TRUE(job->status() == CompileJobStatus::kInitial);
   job->PrepareToParseOnMainThread();
   ASSERT_TRUE(job->status() == CompileJobStatus::kReadyToParse);
   job->Parse();
   ASSERT_TRUE(job->status() == CompileJobStatus::kParsed);
-  job->FinalizeParsingOnMainThread();
+  ASSERT_TRUE(job->FinalizeParsingOnMainThread());
   ASSERT_TRUE(job->status() == CompileJobStatus::kReadyToCompile);
   job->ResetOnMainThread();
   ASSERT_TRUE(job->status() == CompileJobStatus::kInitial);
 }
 
 TEST_F(CompilerDispatcherJobTest, SyntaxError) {
   ScriptResource script("^^^", strlen("^^^"));
   std::unique_ptr<CompilerDispatcherJob> job(new CompilerDispatcherJob(
       i_isolate(), CreateFunction(i_isolate(), &script), FLAG_stack_size));
 
   job->PrepareToParseOnMainThread();
   job->Parse();
-  job->FinalizeParsingOnMainThread();
+  ASSERT_FALSE(job->FinalizeParsingOnMainThread());
+  ASSERT_TRUE(job->status() == CompileJobStatus::kFailed);
+  ASSERT_TRUE(i_isolate()->has_pending_exception());
 
-  ASSERT_TRUE(job->status() == CompileJobStatus::kFailed);
-  ASSERT_FALSE(i_isolate()->has_pending_exception());
-  job->ReportErrorsOnMainThread();
-  ASSERT_TRUE(job->status() == CompileJobStatus::kDone);
-  ASSERT_TRUE(i_isolate()->has_pending_exception());
   i_isolate()->clear_pending_exception();
+
+  job->ResetOnMainThread();
+  ASSERT_TRUE(job->status() == CompileJobStatus::kInitial);
 }
 
 TEST_F(CompilerDispatcherJobTest, ScopeChain) {
   const char script[] =
       "function g() { var g = 1; function f(x) { return x * g }; return f; } "
       "g();";
   Handle<JSFunction> f = Handle<JSFunction>::cast(Utils::OpenHandle(
       *v8::Script::Compile(isolate()->GetCurrentContext(),
                            v8::String::NewFromUtf8(isolate(), script,
                                                    v8::NewStringType::kNormal)
                                .ToLocalChecked())
            .ToLocalChecked()
            ->Run(isolate()->GetCurrentContext())
            .ToLocalChecked()));
 
   std::unique_ptr<CompilerDispatcherJob> job(
       new CompilerDispatcherJob(i_isolate(), f, FLAG_stack_size));
 
   job->PrepareToParseOnMainThread();
   job->Parse();
-  job->FinalizeParsingOnMainThread();
+  ASSERT_TRUE(job->FinalizeParsingOnMainThread());
   ASSERT_TRUE(job->status() == CompileJobStatus::kReadyToCompile);
 
   const AstRawString* var_x =
       job->parse_info_->ast_value_factory()->GetOneByteString("x");
   Variable* var = job->parse_info_->literal()->scope()->Lookup(var_x);
   ASSERT_TRUE(var);
   ASSERT_TRUE(var->IsUnallocated());
 
   const AstRawString* var_g =
       job->parse_info_->ast_value_factory()->GetOneByteString("g");
   var = job->parse_info_->literal()->scope()->Lookup(var_g);
   ASSERT_TRUE(var);
   ASSERT_TRUE(var->IsContextSlot());
 
   job->ResetOnMainThread();
   ASSERT_TRUE(job->status() == CompileJobStatus::kInitial);
 }
 
 }  // namespace internal
 }  // namespace v8