Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 2268983002: Finalizing parsing in a compile job should immediately report errors (Closed)

Created:
4 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 4 months ago
Reviewers:
rmcilroy, marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Finalizing parsing in a compile job should immediately report errors When preparing compilation, we can't delay error reporting either. Also put handles during internalization into a deferred handle scope. BUG=v8:5215 R=marja@chromium.org,rmcilory@chromium.org Committed: https://crrev.com/b79259f6322814d0ce833f03d2e1f4b5a6f1f410 Cr-Commit-Position: refs/heads/master@{#38817}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -58 lines) Patch
M src/compiler-dispatcher/compiler-dispatcher-job.h View 3 chunks +4 lines, -7 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher-job.cc View 4 chunks +30 lines, -44 lines 0 comments Download
M test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
jochen (gone - plz use gerrit)
4 years, 4 months ago (2016-08-23 07:22:12 UTC) #1
marja
lgtm
4 years, 4 months ago (2016-08-23 12:01:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268983002/1
4 years, 4 months ago (2016-08-23 12:08:24 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 12:10:49 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 12:11:00 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b79259f6322814d0ce833f03d2e1f4b5a6f1f410
Cr-Commit-Position: refs/heads/master@{#38817}

Powered by Google App Engine
This is Rietveld 408576698