Rename SecurityOriginCache to URLSecurityOriginMap

Rename SecurityOriginCache to URLSecurityOriginMap

SecurityOriginCache is needed to implement "the origin of the Blob URL"
defined in the File API spec. It's not a cache but a map which needs to
persist. Rename to less confusing name.

This CL also adds comments and do some refactoring around the logic for
readability.

R=mkwst@chromium.org,tommi@chromium.org
BUG=639787
Committed: https://crrev.com/d809019bba4fa9fb90265a64d311826ab3e356e2
Cr-Commit-Position: refs/heads/master@{#416199}

[tyoshino (SeeGerritForStatus), 2016-08-23 07:07:37]

Description was changed from

==========
Rename SecurityOriginCache to URLSecurityOriginMap

SecurityOriginCache is needed to implement "the origin of the Blob URL"
defined in the File API spec. It's not a cache but a map which needs to
persist. Rename to less confusing name.

BUG=639787
==========

to

==========
Rename SecurityOriginCache to URLSecurityOriginMap

SecurityOriginCache is needed to implement "the origin of the Blob URL"
defined in the File API spec. It's not a cache but a map which needs to
persist. Rename to less confusing name.

This CL also adds comments and do some refactoring around the logic for
readability.

BUG=639787
==========

[tyoshino (SeeGerritForStatus), 2016-08-23 07:09:35]

Description was changed from

==========
Rename SecurityOriginCache to URLSecurityOriginMap

SecurityOriginCache is needed to implement "the origin of the Blob URL"
defined in the File API spec. It's not a cache but a map which needs to
persist. Rename to less confusing name.

This CL also adds comments and do some refactoring around the logic for
readability.

BUG=639787
==========

to

==========
Rename SecurityOriginCache to URLSecurityOriginMap

SecurityOriginCache is needed to implement "the origin of the Blob URL"
defined in the File API spec. It's not a cache but a map which needs to
persist. Rename to less confusing name.

This CL also adds comments and do some refactoring around the logic for
readability.

BUG=639787
==========

[tyoshino (SeeGerritForStatus), 2016-08-23 07:09:35]

tyoshino@chromium.org changed reviewers:
+ mkwst@chromium.org, tsepez@chromium.org

[tyoshino (SeeGerritForStatus), 2016-08-23 07:09:41]

The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 07:10:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 08:48:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 08:48:18]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-08-24 01:02:17]

Deferring to Mike.

[Tom Sepez, 2016-08-24 01:02:20]

Deferring to Mike.

[Tom Sepez, 2016-08-24 16:01:07]

tsepez@chromium.org changed reviewers:
- tsepez@chromium.org

[tyoshino (SeeGerritForStatus), 2016-08-25 03:05:14]

On 2016/08/24 16:01:07, Tom Sepez wrote:
> mailto:tsepez@chromium.org changed reviewers:
> - mailto:tsepez@chromium.org

Maybe mkwst@ should be added to weborigin/OWNERS?

[Mike West, 2016-08-31 13:25:09]

Sorry for the delay, I've been OOO for a little while.

With the caveat that I don't like the SecurityOriginCache, and I don't really
understand why we have it rather than parsing the origin out of the blob URL
itself, this rename LGTM.

On 2016/08/25 at 03:05:14, tyoshino wrote:
> On 2016/08/24 16:01:07, Tom Sepez wrote:
> > mailto:tsepez@chromium.org changed reviewers:
> > - mailto:tsepez@chromium.org
> 
> Maybe mkwst@ should be added to weborigin/OWNERS?

mkwst@ is in //platform/OWNERS. *shrug* :)

[tyoshino (SeeGerritForStatus), 2016-09-01 06:22:37]

On 2016/08/31 13:25:09, Mike West (OOO until 29th) wrote:
> Sorry for the delay, I've been OOO for a little while.
> 

Thanks!

> With the caveat that I don't like the SecurityOriginCache, and I don't really
> understand why we have it rather than parsing the origin out of the blob URL
> itself, this rename LGTM.

I think this is e.g. for dealing with Blobs created in a sandboxed Document as
same-origin to the Document and each other. An opaque origin (WHATWG term. Or
globally unique identifier in RFC6454) doesn't get serialized into a Blob URL.

> 
> On 2016/08/25 at 03:05:14, tyoshino wrote:
> > On 2016/08/24 16:01:07, Tom Sepez wrote:
> > > mailto:tsepez@chromium.org changed reviewers:
> > > - mailto:tsepez@chromium.org
> > 
> > Maybe mkwst@ should be added to weborigin/OWNERS?
> 
> mkwst@ is in //platform/OWNERS. *shrug* :)

Yeah. Thought that the fine-grained OWNERS under weborigin should also include
you if you're kinda most familiar to the code in the directory :)

[tyoshino (SeeGerritForStatus), 2016-09-01 06:25:41]

On 2016/09/01 06:22:37, tyoshino wrote:
> > With the caveat that I don't like the SecurityOriginCache, and I don't
really
> > understand why we have it rather than parsing the origin out of the blob URL
> > itself, this rename LGTM.
> 
> I think this is e.g. for dealing with Blobs created in a sandboxed Document as
> same-origin to the Document and each other. An opaque origin (WHATWG term. Or
> globally unique identifier in RFC6454) doesn't get serialized into a Blob URL.

Oh, you might have meant that we should have designed the Blob URL to also
serialize opaque origins by e.g. spawning UUID and embed it.

[tyoshino (SeeGerritForStatus), 2016-09-01 06:26:59]

Description was changed from

==========
Rename SecurityOriginCache to URLSecurityOriginMap

SecurityOriginCache is needed to implement "the origin of the Blob URL"
defined in the File API spec. It's not a cache but a map which needs to
persist. Rename to less confusing name.

This CL also adds comments and do some refactoring around the logic for
readability.

BUG=639787
==========

to

==========
Rename SecurityOriginCache to URLSecurityOriginMap

SecurityOriginCache is needed to implement "the origin of the Blob URL"
defined in the File API spec. It's not a cache but a map which needs to
persist. Rename to less confusing name.

This CL also adds comments and do some refactoring around the logic for
readability.

R=mkwst@chromium.org
BUG=639787
==========

[tyoshino (SeeGerritForStatus), 2016-09-01 06:27:55]

tyoshino@chromium.org changed reviewers:
+ tommi@chromium.org

[tyoshino (SeeGerritForStatus), 2016-09-01 06:28:25]

+tommi to check that what I wrote in URLMediaStream.idl is correct.

[Mike West, 2016-09-01 12:41:54]

On 2016/09/01 at 06:25:41, tyoshino wrote:
> On 2016/09/01 06:22:37, tyoshino wrote:
> > > With the caveat that I don't like the SecurityOriginCache, and I don't
really
> > > understand why we have it rather than parsing the origin out of the blob
URL
> > > itself, this rename LGTM.
> > 
> > I think this is e.g. for dealing with Blobs created in a sandboxed Document
as
> > same-origin to the Document and each other. An opaque origin (WHATWG term.
Or
> > globally unique identifier in RFC6454) doesn't get serialized into a Blob
URL.
> 
> Oh, you might have meant that we should have designed the Blob URL to also
serialize opaque origins by e.g. spawning UUID and embed it.

Or just break blobs inside sandboxes and `data:`. *shrug* But, what's done is
done. :)

[tommi (sloooow) - chröme, 2016-09-01 14:18:18]

lgtm

[tyoshino (SeeGerritForStatus), 2016-09-02 03:37:36]

On 2016/09/01 12:41:54, Mike West (OOO until 29th) wrote:
> On 2016/09/01 at 06:25:41, tyoshino wrote:
> > On 2016/09/01 06:22:37, tyoshino wrote:
> > > > With the caveat that I don't like the SecurityOriginCache, and I don't
> really
> > > > understand why we have it rather than parsing the origin out of the blob
> URL
> > > > itself, this rename LGTM.
> > > 
> > > I think this is e.g. for dealing with Blobs created in a sandboxed
Document
> as
> > > same-origin to the Document and each other. An opaque origin (WHATWG term.
> Or
> > > globally unique identifier in RFC6454) doesn't get serialized into a Blob
> URL.
> > 
> > Oh, you might have meant that we should have designed the Blob URL to also
> serialize opaque origins by e.g. spawning UUID and embed it.
> 
> Or just break blobs inside sandboxes and `data:`. *shrug* But, what's done is
> done. :)

I see!

[tyoshino (SeeGerritForStatus), 2016-09-02 03:58:52]

Description was changed from

==========
Rename SecurityOriginCache to URLSecurityOriginMap

SecurityOriginCache is needed to implement "the origin of the Blob URL"
defined in the File API spec. It's not a cache but a map which needs to
persist. Rename to less confusing name.

This CL also adds comments and do some refactoring around the logic for
readability.

R=mkwst@chromium.org
BUG=639787
==========

to

==========
Rename SecurityOriginCache to URLSecurityOriginMap

SecurityOriginCache is needed to implement "the origin of the Blob URL"
defined in the File API spec. It's not a cache but a map which needs to
persist. Rename to less confusing name.

This CL also adds comments and do some refactoring around the logic for
readability.

R=mkwst@chromium.org,tommi@chromium.org
BUG=639787
==========

[tyoshino (SeeGerritForStatus), 2016-09-02 03:59:00]

The CQ bit was checked by tyoshino@chromium.org

[tyoshino (SeeGerritForStatus), 2016-09-02 03:59:01]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org,
tommi@chromium.org
Link to the patchset: https://codereview.chromium.org/2268973002/#ps60001
(title: "Fix")

[commit-bot: I haz the power, 2016-09-02 03:59:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 06:20:14]

Description was changed from

==========
Rename SecurityOriginCache to URLSecurityOriginMap

SecurityOriginCache is needed to implement "the origin of the Blob URL"
defined in the File API spec. It's not a cache but a map which needs to
persist. Rename to less confusing name.

This CL also adds comments and do some refactoring around the logic for
readability.

R=mkwst@chromium.org,tommi@chromium.org
BUG=639787
==========

to

==========
Rename SecurityOriginCache to URLSecurityOriginMap

SecurityOriginCache is needed to implement "the origin of the Blob URL"
defined in the File API spec. It's not a cache but a map which needs to
persist. Rename to less confusing name.

This CL also adds comments and do some refactoring around the logic for
readability.

R=mkwst@chromium.org,tommi@chromium.org
BUG=639787
==========

[commit-bot: I haz the power, 2016-09-02 06:20:16]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-02 06:21:57]

Description was changed from

==========
Rename SecurityOriginCache to URLSecurityOriginMap

SecurityOriginCache is needed to implement "the origin of the Blob URL"
defined in the File API spec. It's not a cache but a map which needs to
persist. Rename to less confusing name.

This CL also adds comments and do some refactoring around the logic for
readability.

R=mkwst@chromium.org,tommi@chromium.org
BUG=639787
==========

to

==========
Rename SecurityOriginCache to URLSecurityOriginMap

SecurityOriginCache is needed to implement "the origin of the Blob URL"
defined in the File API spec. It's not a cache but a map which needs to
persist. Rename to less confusing name.

This CL also adds comments and do some refactoring around the logic for
readability.

R=mkwst@chromium.org,tommi@chromium.org
BUG=639787

Committed: https://crrev.com/d809019bba4fa9fb90265a64d311826ab3e356e2
Cr-Commit-Position: refs/heads/master@{#416199}
==========

[commit-bot: I haz the power, 2016-09-02 06:21:58]

Patchset 4 (id:??) landed as
https://crrev.com/d809019bba4fa9fb90265a64d311826ab3e356e2
Cr-Commit-Position: refs/heads/master@{#416199}