Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 2268953005: We can't infer the right type for voidp for old png_jmpbuf() (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
msarett
CC:
reviews_skia.org, bungeman-skia
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

We can't infer the right type for voidp for old png_jmpbuf() In libpng 1.2 it's just a macro that's ->jmpbuf, so there's nothing forcing the conversion to png_structp. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2268953005 Committed: https://skia.googlesource.com/skia/+/f84960187ab40281bc4aacf5f6a485579a46f953

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/codec/SkPngCodec.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
mtklein_C
4 years, 3 months ago (2016-08-24 20:48:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268953005/1
4 years, 3 months ago (2016-08-24 20:48:41 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-08-24 20:48:42 UTC) #6
msarett
lgtm
4 years, 3 months ago (2016-08-24 20:49:46 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot/builds/679)
4 years, 3 months ago (2016-08-24 20:50:07 UTC) #9
msarett
4 years, 3 months ago (2016-08-24 20:53:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268953005/1
4 years, 3 months ago (2016-08-24 21:35:03 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-24 21:46:39 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f84960187ab40281bc4aacf5f6a485579a46f953

Powered by Google App Engine
This is Rietveld 408576698