Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 226893002: Revert of [GCM] Adding periodic checkin controlled by G-services settings (Closed)

Created:
6 years, 8 months ago by tommycli
Modified:
6 years, 8 months ago
Reviewers:
Nicolas Zea, jianli, fgorski
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of [GCM] Adding periodic checkin controlled by G-services settings (https://codereview.chromium.org/215363007/) Reason for revert: http://build.chromium.org/p/chromium.mac/builders/Mac10.7%20Tests%20%282%29/builds/25118 These tests fail: gcm_unit_tests: GServicesSettingsDifferentDigest GServicesSettingsSameDigest PeriodicCheckin They should be in the cq, I believe scottmg has filed a bug to put them in the CQ list. Original issue's description: > Adding periodic checkin controlled by G-services settings > > * extracting CheckinRequest::RequestInfo to better manage checkin parameters > * adding G-services settings digest to RequestInfo of the checkin (will be sent with checkin request) > * extracting G-services settings from checkin response > * storing and loading of the G-services settings in GCM Store > > BUG=359254 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261912 TBR=zea@chromium.org,jianli@chromium.org,fgorski@chromium.org NOTREECHECKS=true NOTRY=true BUG=359254 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261916

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -483 lines) Patch
M google_apis/gcm/engine/checkin_request.h View 3 chunks +14 lines, -29 lines 0 comments Download
M google_apis/gcm/engine/checkin_request.cc View 4 chunks +15 lines, -27 lines 0 comments Download
M google_apis/gcm/engine/checkin_request_unittest.cc View 7 chunks +14 lines, -23 lines 0 comments Download
M google_apis/gcm/engine/gcm_store.h View 2 chunks +0 lines, -10 lines 0 comments Download
M google_apis/gcm/engine/gcm_store_impl.h View 1 chunk +0 lines, -6 lines 0 comments Download
M google_apis/gcm/engine/gcm_store_impl.cc View 9 chunks +2 lines, -108 lines 0 comments Download
M google_apis/gcm/engine/gcm_store_impl_unittest.cc View 2 chunks +1 line, -49 lines 0 comments Download
M google_apis/gcm/gcm_client_impl.h View 5 chunks +8 lines, -24 lines 0 comments Download
M google_apis/gcm/gcm_client_impl.cc View 5 chunks +14 lines, -49 lines 0 comments Download
M google_apis/gcm/gcm_client_impl_unittest.cc View 8 chunks +12 lines, -138 lines 0 comments Download
M google_apis/gcm/tools/mcs_probe.cc View 2 chunks +11 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tommycli
Created Revert of [GCM] Adding periodic checkin controlled by G-services settings
6 years, 8 months ago (2014-04-04 23:47:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommycli@chromium.org/226893002/1
6 years, 8 months ago (2014-04-04 23:48:01 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-04 23:49:39 UTC) #3
Message was sent while issue was closed.
Change committed as 261916

Powered by Google App Engine
This is Rietveld 408576698