third_party/WebKit/LayoutTests/media/track/track-cue-rendering-snap-to-lines-not-set.html - Issue 2268923003: Clean up textTrackDisplayElement utility function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/track/track-cue-rendering-snap-to-lines-not-set.html

Issue 2268923003: Clean up textTrackDisplayElement utility function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/track-cue-rendering-rtl.html ('k') | third_party/WebKit/LayoutTests/media/track/track-cue-rendering-tree-is-removed-properly.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/track/track-cue-rendering-snap-to-lines-not-set.html

diff --git a/third_party/WebKit/LayoutTests/media/track/track-cue-rendering-snap-to-lines-not-set.html b/third_party/WebKit/LayoutTests/media/track/track-cue-rendering-snap-to-lines-not-set.html

index 33725d49d2cb694fe5109d25c2ef792ca3161dfe..9010581824e537a0f1eaef8bec23206a5628be12 100644

--- a/third_party/WebKit/LayoutTests/media/track/track-cue-rendering-snap-to-lines-not-set.html

+++ b/third_party/WebKit/LayoutTests/media/track/track-cue-rendering-snap-to-lines-not-set.html

@@ -19,7 +19,7 @@ async_test(function(t) {

var cueDisplayContainer;

video.oncanplaythrough = t.step_func(function() {

- cueDisplayContainer = textTrackDisplayElement(video);

+ cueDisplayContainer = textTrackContainerElement(video);

runNextTestCase();

});

@@ -66,7 +66,7 @@ async_test(function(t) {

function seeked() {

var cuePosition = cueRenderingPosition[seekTimeIndex];

for (var i = 0; i < testTrack.track.activeCues.length; ++i) {

- cueDisplayElement = textTrackDisplayElement(video, "display", i);

+ cueDisplayElement = textTrackCueElementByIndex(video, i);

assert_equals(cueDisplayElement.innerText, testTrack.track.activeCues[i].text);

assert_equals(testTrack.track.activeCues[i].align, cuePosition[i][2]);