Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2268903002: Initialize a member in URLRequestChromeJob. (Closed)

Created:
4 years, 4 months ago by Lei Zhang
Modified:
4 years, 4 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize a member in URLRequestChromeJob. Clean up some nits. BUG=640066 Committed: https://crrev.com/922d34c91c451381eb1ce42f44ee1efb7b33965d Cr-Commit-Position: refs/heads/master@{#413657}

Patch Set 1 #

Patch Set 2 : const auto, git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -24 lines) Patch
M content/browser/webui/url_data_manager_backend.cc View 1 15 chunks +21 lines, -24 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Lei Zhang
4 years, 4 months ago (2016-08-23 02:21:20 UTC) #4
Dan Beam
lgtm
4 years, 4 months ago (2016-08-23 02:24:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268903002/20001
4 years, 4 months ago (2016-08-23 03:37:07 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-23 03:41:33 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 03:43:23 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/922d34c91c451381eb1ce42f44ee1efb7b33965d
Cr-Commit-Position: refs/heads/master@{#413657}

Powered by Google App Engine
This is Rietveld 408576698