Issue 22689003: Use Shill's Manager::ConfigureServiceForProfile for all network types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22689003: Use Shill's Manager::ConfigureServiceForProfile for all network types. (Closed)

Created:
7 years, 4 months ago by pneubeck (no reviews)

Modified:
7 years, 4 months ago

Reviewers:
stevenjb

CC:
chromium-reviews, gauravsh+watch_chromium.org, gspencer+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, Paul Stewart

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use Shill's Manager::ConfigureServiceForProfile for all network types. ConfigureServiceForProfile was only used for WiFi as Shill didn't support other types before https://gerrit.chromium.org/gerrit/63651. This change is helpful for Ethernet EAP policy as well, because Shill will automatically select the EthernetEAP service if the network type is EthernetEAP. BUG=265592, 217524 R=stevenjb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216988

Patch Set 1 : #

Patch Set 2 : Rebased. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -34 lines)			Patch
	M	chromeos/network/network_configuration_handler.cc	View	1	1 chunk	+14 lines, -23 lines	0 comments	Download
	M	chromeos/network/network_configuration_handler_unittest.cc	View		5 chunks	+24 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

stevenjb

lgtm, but should wait for https://codereview.chromium.org/21046008/ to land and be tested with that CL.

7 years, 4 months ago (2013-08-09 00:47:00 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/22689003/7001

7 years, 4 months ago (2013-08-12 13:52:45 UTC) #3

pneubeck (no reviews)

7 years, 4 months ago (2013-08-12 13:56:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r216988 (presubmit successful).

Expand Messages | Collapse Messages