Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h

Issue 2268893008: Remove NeedToDispatchSelectEvent argument of HTMLTextFormControlElement::setSelectedRange(). (Closed)
Patch Set: Remove NeedToDispatchSelectEvent argument of HTMLTextFormControlElement::setSelectedRange(). Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h b/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h
index 54bdc1cca4a4720596814da10fc514c86d40f1fb..dd8b3ae14b142a4cee8c21ad3335dfca42bdb8a9 100644
--- a/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h
@@ -36,7 +36,6 @@ class Range;
enum TextFieldSelectionDirection { SelectionHasNoDirection, SelectionHasForwardDirection, SelectionHasBackwardDirection };
enum TextFieldEventBehavior { DispatchNoEvent, DispatchChangeEvent, DispatchInputAndChangeEvent };
-enum NeedToDispatchSelectEvent { DispatchSelectEvent, NotDispatchSelectEvent };
class CORE_EXPORT HTMLTextFormControlElement : public HTMLFormControlElementWithState {
public:
@@ -75,7 +74,8 @@ public:
void setSelectionRangeForBinding(int start, int end, const String& direction = "none");
// Blink-internal version of setSelectionRange(). This translates "none"
// direction to "forward" on platforms without "none" direction.
- void setSelectionRange(int start, int end, TextFieldSelectionDirection = SelectionHasNoDirection, NeedToDispatchSelectEvent = DispatchSelectEvent);
+ // This returns true if it updated cached selection and/or FrameSelection.
+ bool setSelectionRange(int start, int end, TextFieldSelectionDirection = SelectionHasNoDirection);
Range* selection() const;
virtual bool supportsAutocapitalize() const = 0;

Powered by Google App Engine
This is Rietveld 408576698