Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2268893003: Updated VRPose.timestamp to use same casing as WebVR spec. (Closed)

Created:
4 years, 4 months ago by bajones
Modified:
4 years, 4 months ago
Reviewers:
girard, haraken
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updated VRPose.timestamp to use same casing as WebVR spec. Also changing type to DOMHighResTimeStamp (typedef for double), again to match the spec. See relevant spec text here: https://w3c.github.io/webvr/#interface-vrpose BUG=389343 Committed: https://crrev.com/8b9eb3e957c3ab75cbd97b0ff35060b4677ce8bd Cr-Commit-Position: refs/heads/master@{#413894}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M third_party/WebKit/Source/modules/vr/VRPose.h View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRPose.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRPose.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
bajones
girard@: Quick review please? Simple changes to match spec text.
4 years, 4 months ago (2016-08-23 20:42:39 UTC) #3
girard
lgtm
4 years, 4 months ago (2016-08-23 20:48:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268893003/1
4 years, 4 months ago (2016-08-23 20:53:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 23:23:32 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8b9eb3e957c3ab75cbd97b0ff35060b4677ce8bd Cr-Commit-Position: refs/heads/master@{#413894}
4 years, 4 months ago (2016-08-23 23:26:06 UTC) #10
haraken
4 years, 4 months ago (2016-08-24 00:59:02 UTC) #11
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698