Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Unified Diff: third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHostAPI.js

Issue 2268893002: DevTools: Turn InspectorFrontendHostAPI.Events into symbols. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHostAPI.js
diff --git a/third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHostAPI.js b/third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHostAPI.js
index 1b5e2f3b1719d9b613e299bec0e90720258fdc43..78b02eef60d4371ccd6b7b0d00e64135670d78a7 100644
--- a/third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHostAPI.js
+++ b/third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHostAPI.js
@@ -26,67 +26,67 @@ InspectorFrontendHostAPI.ContextMenuDescriptor;
}} */
InspectorFrontendHostAPI.LoadNetworkResourceResult;
-/** @enum {string} */
+/** @enum {symbol} */
InspectorFrontendHostAPI.Events = {
- AddExtensions: "addExtensions",
- AppendedToURL: "appendedToURL",
- CanceledSaveURL: "canceledSaveURL",
- ContextMenuCleared: "contextMenuCleared",
- ContextMenuItemSelected: "contextMenuItemSelected",
- DeviceCountUpdated: "deviceCountUpdated",
- DevicesDiscoveryConfigChanged: "devicesDiscoveryConfigChanged",
- DevicesPortForwardingStatusChanged: "devicesPortForwardingStatusChanged",
- DevicesUpdated: "devicesUpdated",
- DispatchMessage: "dispatchMessage",
- DispatchMessageChunk: "dispatchMessageChunk",
- EnterInspectElementMode: "enterInspectElementMode",
- EvaluateForTestInFrontend: "evaluateForTestInFrontend",
- FileSystemsLoaded: "fileSystemsLoaded",
- FileSystemRemoved: "fileSystemRemoved",
- FileSystemAdded: "fileSystemAdded",
- FileSystemFilesChanged: "fileSystemFilesChanged",
- IndexingTotalWorkCalculated: "indexingTotalWorkCalculated",
- IndexingWorked: "indexingWorked",
- IndexingDone: "indexingDone",
- KeyEventUnhandled: "keyEventUnhandled",
- ReloadInspectedPage: "reloadInspectedPage",
- RevealSourceLine: "revealSourceLine",
- SavedURL: "savedURL",
- SearchCompleted: "searchCompleted",
- SetInspectedTabId: "setInspectedTabId",
- SetUseSoftMenu: "setUseSoftMenu",
- ShowPanel: "showPanel"
+ AddExtensions: Symbol("addExtensions"),
+ AppendedToURL: Symbol("appendedToURL"),
+ CanceledSaveURL: Symbol("canceledSaveURL"),
+ ContextMenuCleared: Symbol("contextMenuCleared"),
+ ContextMenuItemSelected: Symbol("contextMenuItemSelected"),
+ DeviceCountUpdated: Symbol("deviceCountUpdated"),
+ DevicesDiscoveryConfigChanged: Symbol("devicesDiscoveryConfigChanged"),
+ DevicesPortForwardingStatusChanged: Symbol("devicesPortForwardingStatusChanged"),
+ DevicesUpdated: Symbol("devicesUpdated"),
+ DispatchMessage: Symbol("dispatchMessage"),
+ DispatchMessageChunk: Symbol("dispatchMessageChunk"),
+ EnterInspectElementMode: Symbol("enterInspectElementMode"),
+ EvaluateForTestInFrontend: Symbol("evaluateForTestInFrontend"),
+ FileSystemsLoaded: Symbol("fileSystemsLoaded"),
+ FileSystemRemoved: Symbol("fileSystemRemoved"),
+ FileSystemAdded: Symbol("fileSystemAdded"),
+ FileSystemFilesChanged: Symbol("fileSystemFilesChanged"),
+ IndexingTotalWorkCalculated: Symbol("indexingTotalWorkCalculated"),
+ IndexingWorked: Symbol("indexingWorked"),
+ IndexingDone: Symbol("indexingDone"),
+ KeyEventUnhandled: Symbol("keyEventUnhandled"),
+ ReloadInspectedPage: Symbol("reloadInspectedPage"),
+ RevealSourceLine: Symbol("revealSourceLine"),
+ SavedURL: Symbol("savedURL"),
+ SearchCompleted: Symbol("searchCompleted"),
+ SetInspectedTabId: Symbol("setInspectedTabId"),
+ SetUseSoftMenu: Symbol("setUseSoftMenu"),
+ ShowPanel: Symbol("showPanel")
}
InspectorFrontendHostAPI.EventDescriptors = [
- [InspectorFrontendHostAPI.Events.AddExtensions, ["extensions"]],
- [InspectorFrontendHostAPI.Events.AppendedToURL, ["url"]],
- [InspectorFrontendHostAPI.Events.CanceledSaveURL, ["url"]],
- [InspectorFrontendHostAPI.Events.ContextMenuCleared, []],
- [InspectorFrontendHostAPI.Events.ContextMenuItemSelected, ["id"]],
- [InspectorFrontendHostAPI.Events.DeviceCountUpdated, ["count"]],
- [InspectorFrontendHostAPI.Events.DevicesDiscoveryConfigChanged, ["discoverUsbDevices", "portForwardingEnabled", "portForwardingConfig"]],
- [InspectorFrontendHostAPI.Events.DevicesPortForwardingStatusChanged, ["status"]],
- [InspectorFrontendHostAPI.Events.DevicesUpdated, ["devices"]],
- [InspectorFrontendHostAPI.Events.DispatchMessage, ["messageObject"]],
- [InspectorFrontendHostAPI.Events.DispatchMessageChunk, ["messageChunk", "messageSize"]],
- [InspectorFrontendHostAPI.Events.EnterInspectElementMode, []],
- [InspectorFrontendHostAPI.Events.EvaluateForTestInFrontend, ["callId", "script"]],
- [InspectorFrontendHostAPI.Events.FileSystemsLoaded, ["fileSystems"]],
- [InspectorFrontendHostAPI.Events.FileSystemRemoved, ["fileSystemPath"]],
- [InspectorFrontendHostAPI.Events.FileSystemAdded, ["errorMessage", "fileSystem"]],
- [InspectorFrontendHostAPI.Events.FileSystemFilesChanged, ["paths"]],
- [InspectorFrontendHostAPI.Events.IndexingTotalWorkCalculated, ["requestId", "fileSystemPath", "totalWork"]],
- [InspectorFrontendHostAPI.Events.IndexingWorked, ["requestId", "fileSystemPath", "worked"]],
- [InspectorFrontendHostAPI.Events.IndexingDone, ["requestId", "fileSystemPath"]],
- [InspectorFrontendHostAPI.Events.KeyEventUnhandled, ["event"]],
- [InspectorFrontendHostAPI.Events.ReloadInspectedPage, ["hard"]],
- [InspectorFrontendHostAPI.Events.RevealSourceLine, ["url", "lineNumber", "columnNumber"]],
- [InspectorFrontendHostAPI.Events.SavedURL, ["url"]],
- [InspectorFrontendHostAPI.Events.SearchCompleted, ["requestId", "fileSystemPath", "files"]],
- [InspectorFrontendHostAPI.Events.SetInspectedTabId, ["tabId"]],
- [InspectorFrontendHostAPI.Events.SetUseSoftMenu, ["useSoftMenu"]],
- [InspectorFrontendHostAPI.Events.ShowPanel, ["panelName"]]
+ [InspectorFrontendHostAPI.Events.AddExtensions, "addExtensions", ["extensions"]],
+ [InspectorFrontendHostAPI.Events.AppendedToURL, "appendedToURL", ["url"]],
+ [InspectorFrontendHostAPI.Events.CanceledSaveURL, "canceledSaveURL", ["url"]],
+ [InspectorFrontendHostAPI.Events.ContextMenuCleared, "contextMenuCleared", []],
+ [InspectorFrontendHostAPI.Events.ContextMenuItemSelected, "contextMenuItemSelected", ["id"]],
+ [InspectorFrontendHostAPI.Events.DeviceCountUpdated, "deviceCountUpdated", ["count"]],
+ [InspectorFrontendHostAPI.Events.DevicesDiscoveryConfigChanged, "devicesDiscoveryConfigChanged", ["discoverUsbDevices", "portForwardingEnabled", "portForwardingConfig"]],
+ [InspectorFrontendHostAPI.Events.DevicesPortForwardingStatusChanged, "devicesPortForwardingStatusChanged", ["status"]],
+ [InspectorFrontendHostAPI.Events.DevicesUpdated, "devicesUpdated", ["devices"]],
+ [InspectorFrontendHostAPI.Events.DispatchMessage, "dispatchMessage", ["messageObject"]],
+ [InspectorFrontendHostAPI.Events.DispatchMessageChunk, "dispatchMessageChunk", ["messageChunk", "messageSize"]],
+ [InspectorFrontendHostAPI.Events.EnterInspectElementMode, "enterInspectElementMode", []],
+ [InspectorFrontendHostAPI.Events.EvaluateForTestInFrontend, "evaluateForTestInFrontend", ["callId", "script"]],
+ [InspectorFrontendHostAPI.Events.FileSystemsLoaded, "fileSystemsLoaded", ["fileSystems"]],
+ [InspectorFrontendHostAPI.Events.FileSystemRemoved, "fileSystemRemoved", ["fileSystemPath"]],
+ [InspectorFrontendHostAPI.Events.FileSystemAdded, "fileSystemAdded", ["errorMessage", "fileSystem"]],
+ [InspectorFrontendHostAPI.Events.FileSystemFilesChanged, "fileSystemFilesChanged", ["paths"]],
+ [InspectorFrontendHostAPI.Events.IndexingTotalWorkCalculated, "indexingTotalWorkCalculated", ["requestId", "fileSystemPath", "totalWork"]],
+ [InspectorFrontendHostAPI.Events.IndexingWorked, "indexingWorked", ["requestId", "fileSystemPath", "worked"]],
+ [InspectorFrontendHostAPI.Events.IndexingDone, "indexingDone", ["requestId", "fileSystemPath"]],
+ [InspectorFrontendHostAPI.Events.KeyEventUnhandled, "keyEventUnhandled", ["event"]],
+ [InspectorFrontendHostAPI.Events.ReloadInspectedPage, "reloadInspectedPage", ["hard"]],
+ [InspectorFrontendHostAPI.Events.RevealSourceLine, "revealSourceLine", ["url", "lineNumber", "columnNumber"]],
+ [InspectorFrontendHostAPI.Events.SavedURL, "savedURL", ["url"]],
+ [InspectorFrontendHostAPI.Events.SearchCompleted, "searchCompleted", ["requestId", "fileSystemPath", "files"]],
+ [InspectorFrontendHostAPI.Events.SetInspectedTabId, "setInspectedTabId", ["tabId"]],
+ [InspectorFrontendHostAPI.Events.SetUseSoftMenu, "setUseSoftMenu", ["useSoftMenu"]],
+ [InspectorFrontendHostAPI.Events.ShowPanel, "showPanel", ["panelName"]]
];
InspectorFrontendHostAPI.prototype = {

Powered by Google App Engine
This is Rietveld 408576698