Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: third_party/WebKit/Source/devtools/scripts/compile_frontend.py

Issue 2268893002: DevTools: Turn InspectorFrontendHostAPI.Events into symbols. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHostAPI.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2012 Google Inc. All rights reserved. 2 # Copyright (c) 2012 Google Inc. All rights reserved.
3 # 3 #
4 # Redistribution and use in source and binary forms, with or without 4 # Redistribution and use in source and binary forms, with or without
5 # modification, are permitted provided that the following conditions are 5 # modification, are permitted provided that the following conditions are
6 # met: 6 # met:
7 # 7 #
8 # * Redistributions of source code must retain the above copyright 8 # * Redistributions of source code must retain the above copyright
9 # notice, this list of conditions and the following disclaimer. 9 # notice, this list of conditions and the following disclaimer.
10 # * Redistributions in binary form must reproduce the above 10 # * Redistributions in binary form must reproduce the above
(...skipping 401 matching lines...) Expand 10 before | Expand all | Expand 10 after
412 '--js', to_platform_path(debugger_script_source_name) 412 '--js', to_platform_path(debugger_script_source_name)
413 ] 413 ]
414 414
415 debuggerScriptCompileProc = popen(command) 415 debuggerScriptCompileProc = popen(command)
416 416
417 print 'Compiling devtools.js...' 417 print 'Compiling devtools.js...'
418 418
419 command = spawned_compiler_command + [ 419 command = spawned_compiler_command + [
420 '--externs', to_platform_path(global_externs_file), 420 '--externs', to_platform_path(global_externs_file),
421 '--externs', to_platform_path(path.join(devtools_frontend_path, 'host', 'Ins pectorFrontendHostAPI.js')), 421 '--externs', to_platform_path(path.join(devtools_frontend_path, 'host', 'Ins pectorFrontendHostAPI.js')),
422 '--jscomp_off=externsValidation',
422 '--module', jsmodule_name_prefix + 'devtools_js' + ':1', 423 '--module', jsmodule_name_prefix + 'devtools_js' + ':1',
423 '--js', to_platform_path(path.join(devtools_frontend_path, 'devtools.js')) 424 '--js', to_platform_path(path.join(devtools_frontend_path, 'devtools.js'))
424 ] 425 ]
425 devtoolsJSCompileProc = popen(command) 426 devtoolsJSCompileProc = popen(command)
426 427
427 print 'Verifying JSDoc comments...' 428 print 'Verifying JSDoc comments...'
428 additional_jsdoc_check_files = [injectedScriptSourceTmpFile] 429 additional_jsdoc_check_files = [injectedScriptSourceTmpFile]
429 errors_found |= verify_jsdoc(additional_jsdoc_check_files) 430 errors_found |= verify_jsdoc(additional_jsdoc_check_files)
430 jsdocValidatorProc, jsdocValidatorFileList = verify_jsdoc_extra(additional_jsdoc _check_files) 431 jsdocValidatorProc, jsdocValidatorFileList = verify_jsdoc_extra(additional_jsdoc _check_files)
431 432
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
515 print 'Validate InjectedScriptSource.js output:%s' % os.linesep, (validateInject edScriptOut if validateInjectedScriptOut else '<empty>') 516 print 'Validate InjectedScriptSource.js output:%s' % os.linesep, (validateInject edScriptOut if validateInjectedScriptOut else '<empty>')
516 errors_found |= hasErrors(validateInjectedScriptOut) 517 errors_found |= hasErrors(validateInjectedScriptOut)
517 518
518 if errors_found: 519 if errors_found:
519 print 'ERRORS DETECTED' 520 print 'ERRORS DETECTED'
520 521
521 os.remove(injectedScriptSourceTmpFile) 522 os.remove(injectedScriptSourceTmpFile)
522 os.remove(compiler_args_file.name) 523 os.remove(compiler_args_file.name)
523 os.remove(protocol_externs_file) 524 os.remove(protocol_externs_file)
524 shutil.rmtree(modules_dir, True) 525 shutil.rmtree(modules_dir, True)
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHostAPI.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698