Add a return value to TapWebViewElementWithId

ios/web/public/test/web_view_interaction_test_util.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/web/public/test/web_view_interaction_test_util.h"
 
 #import <Foundation/Foundation.h>
 
 #include "ios/testing/earl_grey/wait_util.h"
 #import "ios/web/web_state/ui/crw_web_controller.h"
 #include "ios/web/web_state/web_state_impl.h"
 
 using web::NavigationManager;
 
 namespace web {
 namespace test {
 
-void TapWebViewElementWithId(web::WebState* web_state,
+bool TapWebViewElementWithId(web::WebState* web_state,
                              const std::string& element_id) {
-  RunActionOnWebViewElementWithId(web_state, element_id, CLICK);
+  return RunActionOnWebViewElementWithId(web_state, element_id, CLICK);
 }
 
-void RunActionOnWebViewElementWithId(web::WebState* web_state,
+bool RunActionOnWebViewElementWithId(web::WebState* web_state,
                                      const std::string& element_id,
                                      ElementAction action) {
   CRWWebController* web_controller =
       static_cast<WebStateImpl*>(web_state)->GetWebController();
   const char* jsAction = nullptr;
   switch (action) {
     case CLICK:
       jsAction = ".click()";
       break;
     case FOCUS:
       jsAction = ".focus();";
       break;
   }
-  NSString* script =
-      [NSString stringWithFormat:@"document.getElementById('%s')%s",
-                                 element_id.c_str(), jsAction];
+  NSString* script = [NSString
+      stringWithFormat:@"(function() {"
+                        "  var element = document.getElementById('%s');"
+                        "  if (element) {"
+                        "    element%s;"
+                        "    return true;"
+                        "  }"
+                        "  return false;"
+                        "})();",
+                       element_id.c_str(), jsAction];

[Eugene But (OOO till 7-30), 2016/08/26 13:19:56]

Could you please s/jsAction/js_action

[jif-google, 2016/08/26 13:30:35]

Acknowledged.

[gambard, 2016/08/26 14:35:52]

Done.

   __block bool did_complete = false;
+  __block bool element_found = false;
   [web_controller executeUserJavaScript:script
-                      completionHandler:^(id, NSError*) {
+                      completionHandler:^(id result, NSError* error) {
                         did_complete = true;
+                        if (!error && result)

[Eugene But (OOO till 7-30), 2016/08/26 13:19:56]

No need for this check if there is an error |result| will be nil. If |result| is
nil then [result boolValue] will return NO;

[jif-google, 2016/08/26 13:30:35]

Acknowledged.

[gambard, 2016/08/26 14:35:52]

Done.

+                          element_found = [result boolValue];
                       }];
 
   testing::WaitUntilCondition(testing::kWaitForJSCompletionTimeout, ^{
     return did_complete;
   });
+
+  return element_found;
 }
 
 }  // namespace test
 }  // namespace web