Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2268863002: MD History: Run polymer-css-build over vulcanized output (Closed)

Created:
4 years, 4 months ago by tsergeant
Modified:
4 years, 3 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, asanka, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org, michaelpg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Run polymer-css-build over vulcanized output polymer-css-build preprocesses CSS to perform transformations ahead-of-time that would otherwise need to be done by the browser during page load. This saves approximately 5% off page load for MD History, and should have a similar impact on MD Downloads. BUG=629406, 629710 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/310a320dfc58f35272e221ba1cad275a6004754d Cr-Commit-Position: refs/heads/master@{#416496}

Patch Set 1 #

Patch Set 2 : Reparent #

Patch Set 3 : Rebase #

Patch Set 4 : MD History: Run polymer-css-build over vulcanized output #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5287 lines, -3784 lines) Patch
M chrome/browser/resources/md_downloads/vulcanized.html View 1 2 3 40 chunks +2016 lines, -1661 lines 0 comments Download
M chrome/browser/resources/md_history/app.vulcanized.html View 1 2 3 48 chunks +3266 lines, -2120 lines 0 comments Download
M chrome/browser/resources/vulcanize.py View 1 chunk +1 line, -0 lines 0 comments Download
M docs/vulcanize.md View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
tsergeant
PTAL.
4 years, 4 months ago (2016-08-23 08:51:08 UTC) #5
Dan Beam
lgtm i find it fairly ironic that michaelpg@ JUST wrote a presubmit[1] to prevent people ...
4 years, 4 months ago (2016-08-24 06:23:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268863002/60001
4 years, 3 months ago (2016-09-05 05:05:02 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-05 05:08:07 UTC) #20
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 05:11:02 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/310a320dfc58f35272e221ba1cad275a6004754d
Cr-Commit-Position: refs/heads/master@{#416496}

Powered by Google App Engine
This is Rietveld 408576698