Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2268843002: queryCommandState should consider the nested list (Closed)

Created:
1 year, 3 months ago by joone
Modified:
1 year, 3 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

queryCommandState should consider the nested list When we run queryCommandState on the nested list, it only finds the parent list so the nested list is not considered. This CL allows the command to find the nested list on the selection. BUG=385374 TEST=editing/execCommand/queryCommandState-list.html Committed: https://crrev.com/9137922eb6ab50e97de5c53a06f553d086d2d862 Cr-Commit-Position: refs/heads/master@{#413764}

Patch Set 1 #

Messages

Total messages: 16 (11 generated)
joone
Hi yosin@ please review this CL.
1 year, 3 months ago (2016-08-23 07:25:37 UTC) #9
yosin_UTC9
lgtm
1 year, 3 months ago (2016-08-23 07:35:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268843002/1
1 year, 3 months ago (2016-08-23 16:50:29 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
1 year, 3 months ago (2016-08-23 16:55:02 UTC) #14
commit-bot: I haz the power
1 year, 3 months ago (2016-08-23 16:57:34 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9137922eb6ab50e97de5c53a06f553d086d2d862
Cr-Commit-Position: refs/heads/master@{#413764}

Powered by Google App Engine
This is Rietveld 0eb02b776