chrome/browser/local_discovery/wifi/wifi_client.cc - Issue 226883002: WiFi client for GCD bootstrapping

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/local_discovery/wifi/wifi_client.cc

Issue 226883002: WiFi client for GCD bootstrapping (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/local_discovery/wifi/wifi_client.h"

	6

	7 #if defined(OS_WIN) \|\| defined(OS_MACOSX)

	8 #include "chrome/browser/local_discovery/wifi/wifi_service_client.h"

	9 #endif

	10

	11 namespace local_discovery {

	12

	13 namespace wifi {

	14

	15 scoped_ptr<WifiClient> WifiClient::Create() {

	16 #if defined(OS_WIN) \|\| defined(OS_MACOSX)

	17 return scoped_ptr<WifiClient>(new WifiServiceClient());

	18 #endif
	stevenjb 2014/05/05 18:19:49 This won't compile on other platforms, you should This won't compile on other platforms, you should #ifdef out the entire method. More commonly this would be put in the implementation file, i.e. wifi_service_client.cc, so no #ifdef is necessary. Noam Samuel 2014/05/05 21:42:51 Done. Show quoted text On 2014/05/05 18:19:49, stevenjb wrote: > This won't compile on other platforms, you should #ifdef out the entire method. > More commonly this would be put in the implementation file, i.e. > wifi_service_client.cc, so no #ifdef is necessary. > Done.
	19 }

	20

	21 } // namespace wifi

	22

	23 } // namespace local_discovery

OLD	NEW