Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2268823006: [Layout API] Use ownerLayoutItem() in LayoutView (part 2) (Closed)

Created:
4 years, 3 months ago by pilgrim_google
Modified:
4 years, 3 months ago
Reviewers:
eae, jsbell
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Layout API] Use ownerLayoutItem() in LayoutView (part 2) Direct access to LayoutPart is deprecated and being removed soon. The replacement is LayoutPartItem, which routes methods through the new block layout API. (See linked crbug for details.) This means the ownerLayoutObject() method is also deprecated, to be replaced with ownerLayoutItem(). There are no functional changes, although I did need to add two methods to LayoutBoxItem. BUG=499321 Committed: https://crrev.com/1708cfe38fe743411644ce08df78d5331ebaaf18 Cr-Commit-Position: refs/heads/master@{#415447}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/api/LayoutBoxItem.h View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
pilgrim_google
4 years, 3 months ago (2016-08-25 16:50:20 UTC) #3
eae
LGTM
4 years, 3 months ago (2016-08-25 18:41:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268823006/1
4 years, 3 months ago (2016-08-25 23:43:31 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/281657)
4 years, 3 months ago (2016-08-26 02:54:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268823006/1
4 years, 3 months ago (2016-08-30 18:23:57 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 21:56:09 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 21:58:30 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1708cfe38fe743411644ce08df78d5331ebaaf18
Cr-Commit-Position: refs/heads/master@{#415447}

Powered by Google App Engine
This is Rietveld 408576698