Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2268823005:
Remove disable_outdated_build_detector_unittests target on 64-bit win10 bot. (Closed)
|
Created:
4 years, 3 months ago by Will Harris Modified:
4 years, 3 months ago Reviewers:
grt (UTC plus 2) CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove disable_outdated_build_detector_unittests target on 64-bit win10 bot.
disable_outdated_build_detector_unittests only builds on 32-bit so having it
as a target on a 64-bit bot makes no sense.
BUG=640667
TBR=dpranke@chromium.org
Committed: https://crrev.com/d150ecb76dc30c56e3d09c07e1f784dd90622017
Cr-Commit-Position: refs/heads/master@{#414195}
Patch Set 1 #
Messages
Total messages: 16 (10 generated)
Description was changed from ========== Remove disable_outdated_build_detector_unittests target on 64-bit win10 bot. disable_outdated_build_detector_unittests only builds on 32-bit so having it as a target on a 64-bit bot makes no sense. BUG=640667 ========== to ========== Remove disable_outdated_build_detector_unittests target on 64-bit win10 bot. disable_outdated_build_detector_unittests only builds on 32-bit so having it as a target on a 64-bit bot makes no sense. BUG=640667 ==========
wfh@chromium.org changed reviewers: + dpranke@chromium.org
The CQ bit was checked by wfh@chromium.org to run a CQ dry run
grt@chromium.org changed reviewers: + grt@chromium.org - dpranke@chromium.org
lgtm, thanks! is it possible to add "64" to the bot name? this seems to be the convention for other bots.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/08/24 20:46:00, grt (UTC plus 2) wrote: > lgtm, thanks! > > is it possible to add "64" to the bot name? this seems to be the convention for > other bots. btw: i think you'll either need to TBR me or send this to one of the testing/buildbot OWNERS (dpranke is one, i think).
okay thanks. I'll push this then do the rename in another CL since I think that is in another repo.
Description was changed from ========== Remove disable_outdated_build_detector_unittests target on 64-bit win10 bot. disable_outdated_build_detector_unittests only builds on 32-bit so having it as a target on a 64-bit bot makes no sense. BUG=640667 ========== to ========== Remove disable_outdated_build_detector_unittests target on 64-bit win10 bot. disable_outdated_build_detector_unittests only builds on 32-bit so having it as a target on a 64-bit bot makes no sense. BUG=640667 TBR=dpranke@chromium.org ==========
The CQ bit was unchecked by wfh@chromium.org
The CQ bit was checked by wfh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove disable_outdated_build_detector_unittests target on 64-bit win10 bot. disable_outdated_build_detector_unittests only builds on 32-bit so having it as a target on a 64-bit bot makes no sense. BUG=640667 TBR=dpranke@chromium.org ========== to ========== Remove disable_outdated_build_detector_unittests target on 64-bit win10 bot. disable_outdated_build_detector_unittests only builds on 32-bit so having it as a target on a 64-bit bot makes no sense. BUG=640667 TBR=dpranke@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove disable_outdated_build_detector_unittests target on 64-bit win10 bot. disable_outdated_build_detector_unittests only builds on 32-bit so having it as a target on a 64-bit bot makes no sense. BUG=640667 TBR=dpranke@chromium.org ========== to ========== Remove disable_outdated_build_detector_unittests target on 64-bit win10 bot. disable_outdated_build_detector_unittests only builds on 32-bit so having it as a target on a 64-bit bot makes no sense. BUG=640667 TBR=dpranke@chromium.org Committed: https://crrev.com/d150ecb76dc30c56e3d09c07e1f784dd90622017 Cr-Commit-Position: refs/heads/master@{#414195} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d150ecb76dc30c56e3d09c07e1f784dd90622017 Cr-Commit-Position: refs/heads/master@{#414195} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
