Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2268823002: mash: Move more shelf files to ash/common/shelf. (Closed)

Created:
4 years, 4 months ago by msw
Modified:
4 years, 4 months ago
Reviewers:
James Cook, sky
CC:
chromium-reviews, pam+watch_chromium.org, achuith+watch_chromium.org, sadrul, dtseng+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, dzhioev+watch_chromium.org, jam, dcheng, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, tfarina, kalyank, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Move more shelf files to ash/common/shelf. tools/git/move_source_file.py ash/shelf/shelf.* ash/common/shelf/ tools/git/move_source_file.py ash/shelf/shelf_layout_manager.* ash/common/shelf/ tools/git/move_source_file.py ash/shelf/shelf_layout_manager_observer.h ash/common/shelf/ tools/git/move_source_file.py ash/shelf/shelf_widget.* ash/common/shelf/ tools/git/move_source_file.py ash/common/shelf/status_area_layout_manager.h ash/common/system/ Update Shelf::ForWindow impl; remove constness of param. Remove DEPS exceptions for moved files. BUG=615155 TEST=Automated; no functional changes. R=jamescook@chromium.org,sky@chromium.org Committed: https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9 Cr-Commit-Position: refs/heads/master@{#413798}

Patch Set 1 #

Patch Set 2 : Nix const; move StatusAreaLayoutManager to ash/common/system. #

Patch Set 3 : Sync and rebase. #

Patch Set 4 : Fix rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -2878 lines) Patch
M ash/accelerators/accelerator_controller_delegate_aura.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/app_list/app_list_presenter_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/ash.gyp View 1 2 6 chunks +9 lines, -9 lines 0 comments Download
M ash/aura/wm_root_window_controller_aura.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/aura/wm_shelf_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/common/shelf/DEPS View 1 chunk +0 lines, -14 lines 0 comments Download
A + ash/common/shelf/shelf.h View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
A + ash/common/shelf/shelf.cc View 1 2 2 chunks +7 lines, -10 lines 0 comments Download
A + ash/common/shelf/shelf_layout_manager.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + ash/common/shelf/shelf_layout_manager.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/shelf/shelf_layout_manager_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/common/shelf/shelf_view.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/shelf/shelf_widget.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + ash/common/shelf/shelf_widget.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ash/common/shelf/wm_shelf.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/shelf/wm_shelf.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + ash/common/system/status_area_layout_manager.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/system/status_area_layout_manager.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ash/content/keyboard_overlay/keyboard_overlay_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/dip_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/display/root_window_transformers_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/display/screen_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/window_tree_host_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/first_run/first_run_helper_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/focus_cycler_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D ash/mus/bridge/DEPS View 1 chunk +0 lines, -8 lines 0 comments Download
M ash/mus/bridge/wm_shelf_mus.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/root_window_controller.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M ash/screen_util.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/shelf/shelf.h View 1 2 1 chunk +0 lines, -138 lines 0 comments Download
D ash/shelf/shelf.cc View 1 2 1 chunk +0 lines, -180 lines 0 comments Download
D ash/shelf/shelf_layout_manager.h View 1 chunk +0 lines, -381 lines 0 comments Download
D ash/shelf/shelf_layout_manager.cc View 1 2 1 chunk +0 lines, -1185 lines 0 comments Download
D ash/shelf/shelf_layout_manager_observer.h View 1 chunk +0 lines, -38 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/shelf/shelf_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shelf/shelf_view_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
D ash/shelf/shelf_widget.h View 1 2 1 chunk +0 lines, -138 lines 0 comments Download
D ash/shelf/shelf_widget.cc View 1 2 1 chunk +0 lines, -539 lines 0 comments Download
M ash/shelf/shelf_widget_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/shell.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ash/shell/window_type_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/window_watcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shell_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/sysui/shelf_delegate_mus.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/test/shelf_test_api.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/status_area_widget_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/dock/docked_window_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/dock/docked_window_resizer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/drag_window_resizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/immersive_fullscreen_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/panels/attached_panel_window_targeter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/panels/panel_window_resizer_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
D ash/wm/status_area_layout_manager.h View 1 chunk +0 lines, -44 lines 0 comments Download
M ash/wm/status_area_layout_manager.cc View 1 1 chunk +0 lines, -65 lines 0 comments Download
M ash/wm/system_gesture_event_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_animations.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/wm/window_cycle_controller_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/workspace_controller_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/accessibility/chromevox_panel.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/first_run/steps/tray_step.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/profiles/multiprofiles_session_aborted_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/shelf_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/first_run/first_run_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (14 generated)
msw
Hey James and Scott, PTAL at ash/* and chrome/* respectively; thanks!
4 years, 4 months ago (2016-08-23 00:31:20 UTC) #4
sky
chrome LGTM
4 years, 4 months ago (2016-08-23 13:21:52 UTC) #9
James Cook
ash LGTM
4 years, 4 months ago (2016-08-23 16:14:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268823002/40001
4 years, 4 months ago (2016-08-23 17:06:42 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/251242)
4 years, 4 months ago (2016-08-23 17:34:06 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268823002/2
4 years, 4 months ago (2016-08-23 17:59:17 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:2)
4 years, 4 months ago (2016-08-23 18:56:55 UTC) #20
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 18:58:57 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/df64c66b915f64f2356cdecd0450f3bf75f144b9
Cr-Commit-Position: refs/heads/master@{#413798}

Powered by Google App Engine
This is Rietveld 408576698