Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: components/crash/core/browser/resources/crashes.js

Issue 2268783002: Manual crash uploads for mac and win (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/crash/core/browser/resources/crashes.js
diff --git a/components/crash/core/browser/resources/crashes.js b/components/crash/core/browser/resources/crashes.js
index efd5912becd27c284a55b3cb216093b535022db8..47a660bedf13f8bc2a4fd8132819e13f8243c73b 100644
--- a/components/crash/core/browser/resources/crashes.js
+++ b/components/crash/core/browser/resources/crashes.js
@@ -16,11 +16,14 @@ function requestCrashes() {
* Callback from backend with the list of crashes. Builds the UI.
* @param {boolean} enabled Whether or not crash reporting is enabled.
* @param {boolean} dynamicBackend Whether the crash backend is dynamic.
+ * @param {boolean} manualUploads Whether the manual uploads are supported.
* @param {array} crashes The list of crashes.
* @param {string} version The browser version.
* @param {string} os The OS name and version.
*/
-function updateCrashList(enabled, dynamicBackend, crashes, version, os) {
+function updateCrashList(
+ enabled, dynamicBackend, manualUploads,
+ crashes, version, os) {
$('countBanner').textContent =
loadTimeData.getStringF('crashCountFormat',
crashes.length.toLocaleString());
@@ -102,16 +105,36 @@ function updateCrashList(enabled, dynamicBackend, crashes, version, os) {
link.textContent = loadTimeData.getString('bugLinkText');
linkBlock.appendChild(link);
crashBlock.appendChild(linkBlock);
- } else if (crash['state'] == 'pending') {
- var pending = document.createElement('p');
- pending.textContent = loadTimeData.getStringF('crashPending',
- crash['time']);
- crashBlock.appendChild(pending);
- } else if (crash['state'] == 'not_uploaded') {
- var not_uploaded = document.createElement('p');
- not_uploaded.textContent = loadTimeData.getStringF('crashNotUploaded',
- crash['time']);
- crashBlock.appendChild(not_uploaded);
+ } else if (crash['state'] == 'user_requested') {
+ var user_requested = document.createElement('p');
+ user_requested.textContent =
+ loadTimeData.getStringF('crashUserRequested', crash['time']);
+ crashBlock.appendChild(user_requested);
+ } else {
+ if (crash['state'] == 'pending') {
+ var pending = document.createElement('p');
+ pending.textContent = loadTimeData.getStringF('crashPending',
+ crash['time']);
+ crashBlock.appendChild(pending);
+ } else if (crash['state'] == 'not_uploaded') {
+ var not_uploaded = document.createElement('p');
+ not_uploaded.textContent = loadTimeData.getStringF('crashNotUploaded',
+ crash['time']);
+ crashBlock.appendChild(not_uploaded);
+ }
+
+ if (manualUploads) {
+ var uploadNowLinkBlock = document.createElement('p');
+ var link = document.createElement('a');
+ link.href = '';
+ link.textContent = loadTimeData.getString('uploadNowLinkText');
+ link['local_id'] = crash['local_id'];
+ link.onclick = function() {
+ chrome.send('requestSingleCrashUpload', [this['local_id']]);
+ }
+ uploadNowLinkBlock.appendChild(link);
+ crashBlock.appendChild(uploadNowLinkBlock)
+ }
}
crashSection.appendChild(crashBlock);
}
@@ -135,4 +158,4 @@ function requestCrashUpload() {
document.addEventListener('DOMContentLoaded', function() {
$('uploadCrashes').onclick = requestCrashUpload;
requestCrashes();
-});
+});

Powered by Google App Engine
This is Rietveld 408576698