Manual crash uploads for mac and win

components/upload_list/upload_list.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/upload_list/upload_list.h"
 
 #include <algorithm>
 #include <iterator>
 #include <utility>
 
@@ skipping 115 matching lines @@
     delegate_->OnUploadListAvailable();
 }
 
 void UploadList::GetUploads(size_t max_count,
                             std::vector<UploadInfo>* uploads) {
   DCHECK(thread_checker_.CalledOnValidThread());
   std::copy(uploads_.begin(),
             uploads_.begin() + std::min(uploads_.size(), max_count),
             std::back_inserter(*uploads));
 }
+
+void UploadList::RequestSingleCrashUploadAsync(const std::string& local_id) {
+#if defined(OS_WIN) || defined(OS_MACOSX)
+  DCHECK(thread_checker_.CalledOnValidThread());
+  worker_pool_->PostTask(
+      FROM_HERE,
+      base::Bind(&UploadList::RequestSingleCrashUpload, this, local_id));
+#endif
+}
+
+void UploadList::RequestSingleCrashUpload(const std::string& local_id) {
+  // Manual uploads for not uploaded crash reports are not availble for non

[jwd, 2016/08/23 19:14:30]

availble -> available

[gayane -on leave until 09-2017, 2016/08/23 20:57:45]

Done.

+  // crashpad systems.
+  NOTREACHED();

[jwd, 2016/08/23 19:14:30]

I wonder if this function should be defined here at all. You could make
RequestSingleCrashUploadAsync virtual with the NOTREACHED, and just implement it
properly in the crashpad version, and have a RequestSingleCrashUpload defined
there only, no?

[gayane -on leave until 09-2017, 2016/08/23 20:57:45]

initially i did it like you suggested, but then I thought that if we are going
to add Android part then we will just need to implementRequestSingleCrashUpload
in here and Async will be common for all the platforms.

[jwd, 2016/08/24 15:09:19]

Ok, can you add a comment that this is here to support android later?

+}