Manual crash uploads for mac and win

chrome/browser/crash_upload_list/crash_upload_list_crashpad.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/crash_upload_list/crash_upload_list_crashpad.h"
 
 #include <stddef.h>
 
 #include "base/threading/sequenced_worker_pool.h"
 #include "base/time/time.h"
@@ skipping 20 matching lines @@
   }();
 
   if (get_crash_reports) {
     const crash_reporter::Report* reports_pointer;
     size_t report_count;
     get_crash_reports(&reports_pointer, &report_count);
     *reports = std::vector<crash_reporter::Report>(
         reports_pointer, reports_pointer + report_count);
   }
 }
+
+void RequestSingleCrashUploadThunk(const std::string& local_id) {
+  // The crash reporting is handled by chrome_elf.dll which loads early in
+  // the chrome process.
+  HMODULE elf_module = GetModuleHandle(chrome::kChromeElfDllName);
+  if (elf_module) {
+    static RequestSingleCrashUploadPointer request_single_crash_upload =
+        reinterpret_cast<RequestSingleCrashUploadPointer>(
+            GetProcAddress(elf_module, "RequestSingleCrashUploadImpl"));

[jwd, 2016/08/23 19:14:30]

Can you pull the string out into a constant in the anonymous namespace, and add
some comment to it, similar to
https://cs.chromium.org/chromium/src/chrome/browser/metrics/chrome_metrics_se...

[gayane -on leave until 09-2017, 2016/08/23 20:57:45]

Done.

+
+    if (request_single_crash_upload)
+      request_single_crash_upload(local_id);
+  }
+}
+
 #endif  // OS_WIN
 
 UploadList::UploadInfo::State ReportUploadStateToUploadInfoState(
     crash_reporter::ReportUploadState state) {
   switch (state) {
     case crash_reporter::ReportUploadState::NotUploaded:
       return UploadList::UploadInfo::State::NotUploaded;
 
     case crash_reporter::ReportUploadState::Pending:
       return UploadList::UploadInfo::State::Pending;
 
     case crash_reporter::ReportUploadState::Uploaded:
       return UploadList::UploadInfo::State::Uploaded;
+
+    case crash_reporter::ReportUploadState::UserRequested:
+      return UploadList::UploadInfo::State::UserRequested;
   }
 
   NOTREACHED();
   return UploadList::UploadInfo::State::Uploaded;
 }
 
 }  // namespace
 
 CrashUploadListCrashpad::CrashUploadListCrashpad(
     Delegate* delegate,
@@ skipping 15 matching lines @@
   crash_reporter::GetReports(&reports);
 #endif
 
   for (const crash_reporter::Report& report : reports) {
     uploads->push_back(
         UploadInfo(report.remote_id, base::Time::FromTimeT(report.upload_time),
                    report.local_id, base::Time::FromTimeT(report.capture_time),
                    ReportUploadStateToUploadInfoState(report.state)));
   }
 }
+
+void CrashUploadListCrashpad::RequestSingleCrashUpload(
+    const std::string& local_id) {
+#if defined(OS_WIN)
+  // On Windows, we only link crash client into chrome.exe (not the dlls), and
+  // it does the registration. That means the global that holds the crash report
+  // database lives in the .exe, so we need to grab a pointer to a helper in the
+  // exe.

[jwd, 2016/08/23 19:14:30]

I don't think this is a good way of explaining it. At least, I find it
confusing. I understood it that it lives in the chrome_elf.dll, not chrome.exe,
but I don't actually have a good understanding.

I think it's probably sufficient to say that crash reporting is handled by
chrome_elf.dll, and we can't call crash_reporter::RequestSingleCrashUpload
directly.

I'd not mention the pointer details here.

[gayane -on leave until 09-2017, 2016/08/23 20:57:45]

Done.

+  RequestSingleCrashUploadThunk(local_id);
+#else
+  crash_reporter::RequestSingleCrashUpload(local_id);
+#endif
+}