Support css clip on fixed-position GeometryMapper

Support css clip on fixed-position GeometryMapper

Previously in GeometryMapper::mapToVisualRectInDestinationSpace(), if
the fast path localToVisualRectToAncestorSpace() doesn't work because
the transform node of destinationSpace is not an ancestor of the
transform node of sourceState, we fallback to the slow path which
previously didn't support clip.

Now support clip if possible in the slow path.

BUG=638386
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/7b7daf557bcc65228cb1431dc3f9f9b8547fd9c9
Cr-Commit-Position: refs/heads/master@{#413652}

[Xianzhu, 2016-08-22 21:24:44]

Description was changed from

==========
Support css clip on fixed-position GeometryMapper

Previously in GeometryMapper::mapToVisualRectInDestinationSpace(), if
the fast path localToVisualRectToAncestorSpace() doesn't work because
the transform node of destinationSpace is not an ancestor of the
transform node of sourceState, we fallback to the slow path which
previously didn't support clip.

Now support clip if possible in the slow path.

BUG=638386
==========

to

==========
Support css clip on fixed-position GeometryMapper

Previously in GeometryMapper::mapToVisualRectInDestinationSpace(), if
the fast path localToVisualRectToAncestorSpace() doesn't work because
the transform node of destinationSpace is not an ancestor of the
transform node of sourceState, we fallback to the slow path which
previously didn't support clip.

Now support clip if possible in the slow path.

BUG=638386
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-08-22 21:25:51]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 21:26:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-08-22 21:50:17]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[Xianzhu, 2016-08-22 22:09:35]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 22:10:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2016-08-22 22:27:32]

https://codereview.chromium.org/2268773002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp
(left):

https://codereview.chromium.org/2268773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp:147: bool
success = false;
Why remove this line? Reset success to false each time at least right?

https://codereview.chromium.org/2268773002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp
(right):

https://codereview.chromium.org/2268773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp:173: //
It's illegal to ask for a local-to-ancestor clip when the ancestor is not an
ancestor.
Remove this comment.

https://codereview.chromium.org/2268773002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h (right):

https://codereview.chromium.org/2268773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h:112:
FloatRect slowMapToVisualRectInDestinationSpace(const FloatRect&,
Please add a direct unittest to GeometryMapperTest to exercise this code, for
completeness.

[Xianzhu, 2016-08-22 23:30:20]

https://codereview.chromium.org/2268773002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp
(left):

https://codereview.chromium.org/2268773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp:147: bool
success = false;
On 2016/08/22 22:27:31, chrishtr wrote:
> Why remove this line? Reset success to false each time at least right?

Changed to
       success = false;
       const TransformationMatrix transformMatrix =
localToAncestorMatrix((*it)->localTransformSpace(), ancestorState, success);
       if (!success)
           return clip;

and added
  success = true before new line 191.

https://codereview.chromium.org/2268773002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp
(right):

https://codereview.chromium.org/2268773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp:173: //
It's illegal to ask for a local-to-ancestor clip when the ancestor is not an
ancestor.
On 2016/08/22 22:27:31, chrishtr wrote:
> Remove this comment.

Done.

https://codereview.chromium.org/2268773002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h (right):

https://codereview.chromium.org/2268773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h:112:
FloatRect slowMapToVisualRectInDestinationSpace(const FloatRect&,
On 2016/08/22 22:27:32, chrishtr wrote:
> Please add a direct unittest to GeometryMapperTest to exercise this code, for
> completeness.

Done.

[Xianzhu, 2016-08-22 23:38:17]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 23:39:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2016-08-22 23:45:16]

lgtm

[commit-bot: I haz the power, 2016-08-23 01:59:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 01:59:49]

Dry run: This issue passed the CQ dry run.

[Xianzhu, 2016-08-23 03:07:15]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-08-23 03:07:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 03:12:16]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-23 03:18:06]

Description was changed from

==========
Support css clip on fixed-position GeometryMapper

Previously in GeometryMapper::mapToVisualRectInDestinationSpace(), if
the fast path localToVisualRectToAncestorSpace() doesn't work because
the transform node of destinationSpace is not an ancestor of the
transform node of sourceState, we fallback to the slow path which
previously didn't support clip.

Now support clip if possible in the slow path.

BUG=638386
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Support css clip on fixed-position GeometryMapper

Previously in GeometryMapper::mapToVisualRectInDestinationSpace(), if
the fast path localToVisualRectToAncestorSpace() doesn't work because
the transform node of destinationSpace is not an ancestor of the
transform node of sourceState, we fallback to the slow path which
previously didn't support clip.

Now support clip if possible in the slow path.

BUG=638386
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/7b7daf557bcc65228cb1431dc3f9f9b8547fd9c9
Cr-Commit-Position: refs/heads/master@{#413652}
==========

[commit-bot: I haz the power, 2016-08-23 03:18:07]

Patchset 5 (id:??) landed as
https://crrev.com/7b7daf557bcc65228cb1431dc3f9f9b8547fd9c9
Cr-Commit-Position: refs/heads/master@{#413652}