Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issue 2268753002: [Autofill] Declare profile cleanup field trial groups for testing (Closed)

Created:
4 years, 4 months ago by Roger McFarlane (Chromium)
Modified:
4 years, 4 months ago
Reviewers:
sebsg, rkaplow, jwd
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Declare profile cleanup field trial groups for testing BUG=620414 Committed: https://crrev.com/29ce34bbfce5098eaf0dd58bee61635a6acd4336 Cr-Commit-Position: refs/heads/master@{#414070}

Patch Set 1 #

Patch Set 2 : only test enabled groups #

Patch Set 3 : [Autofill] Declare profile cleanup field trial groups for testing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
M testing/variations/fieldtrial_testing_config_android.json View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_chromeos.json View 1 1 chunk +8 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_ios.json View 1 1 chunk +8 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_linux.json View 1 1 chunk +8 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_mac.json View 1 1 chunk +8 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_win.json View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (14 generated)
Roger McFarlane (Chromium)
PTAL?
4 years, 4 months ago (2016-08-22 20:24:32 UTC) #3
rkaplow
you can remove the disabled groups - we will start testing just enabled. THese configs ...
4 years, 4 months ago (2016-08-22 20:33:31 UTC) #5
Roger McFarlane (Chromium)
Thanks. Another look?
4 years, 4 months ago (2016-08-23 15:08:32 UTC) #10
sebsg
lgtm
4 years, 4 months ago (2016-08-23 15:13:38 UTC) #11
Roger McFarlane (Chromium)
rkaplow@ - ping?
4 years, 4 months ago (2016-08-23 18:26:50 UTC) #14
Roger McFarlane (Chromium)
+jwd
4 years, 4 months ago (2016-08-23 21:11:52 UTC) #16
jwd
lgtm
4 years, 4 months ago (2016-08-23 21:47:12 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268753002/20001
4 years, 4 months ago (2016-08-23 21:51:25 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/128313)
4 years, 4 months ago (2016-08-23 23:45:06 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268753002/20001
4 years, 4 months ago (2016-08-24 14:11:31 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-24 14:53:29 UTC) #24
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/29ce34bbfce5098eaf0dd58bee61635a6acd4336 Cr-Commit-Position: refs/heads/master@{#414070}
4 years, 4 months ago (2016-08-24 14:55:02 UTC) #26
Xi Han
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2276103003/ by hanxi@chromium.org. ...
4 years, 4 months ago (2016-08-24 18:42:08 UTC) #27
Roger McFarlane (Chromium)
4 years, 4 months ago (2016-08-24 18:47:45 UTC) #28
Message was sent while issue was closed.
On 2016/08/24 18:42:08, Xi Han wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/2276103003/ by mailto:hanxi@chromium.org.
> 
> The reason for reverting is: crbug.com/640669
> This CL causes chrome_sync_shell_test_apk on Android failing on
> chromium.linux/Android Tests..

Investigating...

Powered by Google App Engine
This is Rietveld 408576698