Update fixed-right-in-page-scale.html in an attempt to make it pass

Update fixed-right-in-page-scale.html in an attempt to make it pass

TBR=pdr@chromium.org
BUG=592185, 636475
Committed: https://crrev.com/b95ffcacefd18d2ebe71bb232d14430cca327c0d
Cr-Commit-Position: refs/heads/master@{#414091}

[pdr., 2016-08-22 21:26:08]

This looks good overall but what was causing it to fail? Was it just the scroll
animator? If so, do all of the other scrollTo() calls in fast/repaint need
similar fixes?

https://codereview.chromium.org/2268733002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/repaint/fixed-right-in-page-scale.html
(right):

https://codereview.chromium.org/2268733002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/repaint/fixed-right-in-page-scale.html:20:
if (window.internals) {
Nit: no need for extra curlies

[Stephen Chennney, 2016-08-24 14:59:12]

On 2016/08/22 21:26:08, pdr. wrote:
> This looks good overall but what was causing it to fail? Was it just the
scroll
> animator? If so, do all of the other scrollTo() calls in fast/repaint need
> similar fixes?

Not sure. This one probably has something to do with the scale change too. This
was mostly a speculative fix.
 
>
https://codereview.chromium.org/2268733002/diff/20001/third_party/WebKit/Layo...
> File
third_party/WebKit/LayoutTests/fast/repaint/fixed-right-in-page-scale.html
> (right):
> 
>
https://codereview.chromium.org/2268733002/diff/20001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/fast/repaint/fixed-right-in-page-scale.html:20:
> if (window.internals) {
> Nit: no need for extra curlies

I was matching exactly fixed-right-bottom-in-page-scale. I'll just update them
both and upload a new patch. This one probably conflicts now anyway.

[Stephen Chennney, 2016-08-24 15:34:25]

The CQ bit was checked by schenney@chromium.org

[commit-bot: I haz the power, 2016-08-24 15:35:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 16:49:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-24 16:51:14]

Description was changed from

==========
Update fixed-right-in-page-scale.html in an attempt to make it pass

TBR=pdr@chromium.org
BUG=592185,636475
==========

to

==========
Update fixed-right-in-page-scale.html in an attempt to make it pass

TBR=pdr@chromium.org
BUG=592185,636475

Committed: https://crrev.com/b95ffcacefd18d2ebe71bb232d14430cca327c0d
Cr-Commit-Position: refs/heads/master@{#414091}
==========

[commit-bot: I haz the power, 2016-08-24 16:51:15]

Patchset 3 (id:??) landed as
https://crrev.com/b95ffcacefd18d2ebe71bb232d14430cca327c0d
Cr-Commit-Position: refs/heads/master@{#414091}

[pdr., 2016-08-24 17:13:34]

https://codereview.chromium.org/2268733002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2268733002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:61: crbug.com/598051
svg/overflow/overflow-on-foreignObject.svg [ Skip ]
Did this patch undo https://codereview.chromium.org/2269963004 ?

[Stephen Chennney, 2016-08-24 18:34:01]

On 2016/08/24 17:13:34, pdr. wrote:
>
https://codereview.chromium.org/2268733002/diff/40001/third_party/WebKit/Layo...
> File third_party/WebKit/LayoutTests/TestExpectations (right):
> 
>
https://codereview.chromium.org/2268733002/diff/40001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/TestExpectations:61: crbug.com/598051
> svg/overflow/overflow-on-foreignObject.svg [ Skip ]
> Did this patch undo https://codereview.chromium.org/2269963004 ?

Apparently. I'll fix that.