Source/bindings/scripts/deprecated_code_generator_v8.pm - Issue 22687002: Treat non-callable input as null for EventHandler attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/deprecated_code_generator_v8.pm

Issue 22687002: Treat non-callable input as null for EventHandler attributes (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Take arv's feedback into consideration Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/html/eventhandler-attribute-non-callable.html ('K') | « LayoutTests/fast/html/eventhandler-attribute-non-callable-expected.txt ('k') | Source/bindings/tests/results/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/scripts/deprecated_code_generator_v8.pm

diff --git a/Source/bindings/scripts/deprecated_code_generator_v8.pm b/Source/bindings/scripts/deprecated_code_generator_v8.pm

index ce077eefbe1f6408512706df8333bc54ee016185..65f721b924d2848c8709f84a183d08cd68c92cb9 100644

--- a/Source/bindings/scripts/deprecated_code_generator_v8.pm

+++ b/Source/bindings/scripts/deprecated_code_generator_v8.pm

@@ -1852,6 +1852,9 @@ END

if ($attribute->type eq "EventHandler") {

my $implSetterFunctionName = FirstLetterToUpperCase($attrName);

AddToImplIncludes("bindings/v8/V8AbstractEventListener.h");

+ # Non callable input should be treated as null

+ $code .= " if (!value->IsNull() && !value->IsFunction())\n";

+ $code .= " value = v8::Null(info.GetIsolate());\n";

if (!InheritsInterface($interface, "Node")) {

my $attrImplName = GetImplName($attribute);

$code .= " transferHiddenDependency(info.Holder(), imp->${attrImplName}(isolatedWorldForIsolate(info.GetIsolate())), value, ${v8ClassName}::eventListenerCacheIndex, info.GetIsolate());\n";