LayoutTests/fast/html/eventhandler-attribute-non-callable.html - Issue 22687002: Treat non-callable input as null for EventHandler attributes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/html/eventhandler-attribute-non-callable.html

Issue 22687002: Treat non-callable input as null for EventHandler attributes (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Take Kentaro's feedback into consideration Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/fast/dom/Window/get-set-properties.html ('K') | « LayoutTests/fast/dom/exception-getting-event-handler.html ('k') | LayoutTests/fast/html/eventhandler-attribute-non-callable-expected.txt » ('j') | Source/bindings/v8/V8EventListener.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <link rel="help" href="http://www.whatwg.org/specs/web-apps/current-work/multipa ge/webappapis.html#eventhandler">

	4 <script src="../js/resources/js-test-pre.js"></script>

	5 </head>

	6 <body>

	7 <div id="div"></div>

	8 <script>

	9 description("This test checks that EventHandler attributes only accept JS functi ons as input.");

	10

	11 var div = document.getElementById("div");

	12 var wasCallbackCalled = false;
	arv (Not doing code reviews) 2013/08/08 14:41:28 A general tip for cases like this is to use a coun A general tip for cases like this is to use a counter instead. That way it catches bugs where a callback is called too often.
	13

	14 function callback() {

	15 wasCallbackCalled = true;

	16 }

	17

	18 function dispatchKeyEvent()

	19 {

	20 var event = document.createEvent("KeyboardEvent");
	arv (Not doing code reviews) 2013/08/08 14:41:28 I always prefer new FooEvent since the initFooEven I always prefer new FooEvent since the initFooEvent pattern is impossible to remember.
	21 event.initKeyboardEvent("keydown", true, true, null, "Enter", "");

	22 div.dispatchEvent(event);

	23 }

	24

	25 // Input is a JS function, this should work.

	26 shouldBeNull('div.onkeydown');

	27 shouldNotThrow('div.onkeydown = callback');

	28 shouldBe('div.onkeydown', 'callback');

	29 dispatchKeyEvent();

	30 shouldBeTrue('wasCallbackCalled');

	31

	32 // Non callable input should be treated as null.

	33 var o = {};

	34 Object.defineProperty(o, 'handleEvent', callback);
	arv (Not doing code reviews) 2013/08/08 14:41:28 This is incorrect usage of the defineProperty API. This is incorrect usage of the defineProperty API. The third param should be a property descriptor... but the following code is cleaner: var o = {handleEvent: callback};
	35 shouldNotBe('div.onkeydown', 'null');

	36 shouldNotThrow('div.onkeydown = o');

	37 shouldBeNull('div.onkeydown');

	38 wasCallbackCalled = false;

	39 dispatchKeyEvent();

	40 shouldBeFalse('wasCallbackCalled');

	41

	42 // Test null assignment.

	43 shouldNotThrow('div.onkeydown = callback');

	44 shouldBe('div.onkeydown', 'callback');

	45 shouldNotThrow('div.onkeydown = null');

	46 shouldBeNull('div.onkeydown');

	47 </script>

	48 <script src="../js/resources/js-test-post.js"></script>

	49 </body>

	50 </html>

OLD	NEW