Fix more integer overflows inside ReadPageHintTable().

Fix more integer overflows inside ReadPageHintTable().

BUG=637119
Committed: https://pdfium.googlesource.com/pdfium/+/7da24e66c6e78a7675697ecec641e3802ff722ca

[Lei Zhang, 2016-08-22 21:03:59]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 21:04:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 21:15:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 21:15:54]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-08-22 21:28:41]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Tom Sepez, 2016-08-23 00:09:16]

https://codereview.chromium.org/2268693003/diff/1/core/fxcrt/fx_basic_buffer.cpp
File core/fxcrt/fx_basic_buffer.cpp (right):

https://codereview.chromium.org/2268693003/diff/1/core/fxcrt/fx_basic_buffer....
core/fxcrt/fx_basic_buffer.cpp:192: int mod = m_BitPos % 8;
Is m_BitPos unsigned?  It should be.  Make |mod| match if needed.
Can't we do this without multiplications?  (x + 7) & ~7 or some such?

[Lei Zhang, 2016-08-23 00:33:12]

https://codereview.chromium.org/2268693003/diff/1/core/fxcrt/fx_basic_buffer.cpp
File core/fxcrt/fx_basic_buffer.cpp (right):

https://codereview.chromium.org/2268693003/diff/1/core/fxcrt/fx_basic_buffer....
core/fxcrt/fx_basic_buffer.cpp:192: int mod = m_BitPos % 8;
On 2016/08/23 00:09:16, Tom Sepez (Offsite til 8-23) wrote:
> Is m_BitPos unsigned?  It should be.  Make |mod| match if needed.
> Can't we do this without multiplications?  (x + 7) & ~7 or some such?

Uhh, wasn't looking that hard. Done.

[Lei Zhang, 2016-08-23 00:33:23]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 00:33:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-08-23 00:35:18]

lgtm

[commit-bot: I haz the power, 2016-08-23 00:44:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 00:44:14]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-08-23 00:46:48]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-08-23 00:46:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 00:47:13]

Description was changed from

==========
Fix more integer overflows inside ReadPageHintTable().

BUG=637119
==========

to

==========
Fix more integer overflows inside ReadPageHintTable().

BUG=637119

Committed:
https://pdfium.googlesource.com/pdfium/+/7da24e66c6e78a7675697ecec641e3802ff7...
==========

[commit-bot: I haz the power, 2016-08-23 00:47:14]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/7da24e66c6e78a7675697ecec641e3802ff7...