Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2268663002: Add simple font fallback on Mac. (Closed)

Created:
4 years, 3 months ago by bungeman-skia
Modified:
4 years, 3 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add simple font fallback on Mac. Implement SkFontMgr_Mac::onMatchFamilyStyleCharacter. This is a simple implementation which provides basic fallback. This also renames and refactors several static functions to reduce code duplication. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2268663002 Committed: https://skia.googlesource.com/skia/+/bea9748449e9d0ab6e2e17fe206931afd81613e5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -64 lines) Patch
M src/ports/SkFontHost_mac.cpp View 11 chunks +75 lines, -64 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
bungeman-skia
4 years, 3 months ago (2016-08-22 20:21:09 UTC) #8
mtklein
lgtm
4 years, 3 months ago (2016-08-24 15:06:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268663002/1
4 years, 3 months ago (2016-08-24 15:06:57 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-24 15:29:53 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bea9748449e9d0ab6e2e17fe206931afd81613e5

Powered by Google App Engine
This is Rietveld 408576698