content/public/common/connection_filter.h - Issue 2268603002: Avoid UAF on ConnectionFilter impls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/connection_filter.h

Issue 2268603002: Avoid UAF on ConnectionFilter impls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/common/connection_filter.h

diff --git a/content/public/common/connection_filter.h b/content/public/common/connection_filter.h

index 60679a865ad3a26118b4eb9d833f961115ccb01c..daa864b24b6afd99db5ba98a6c1f142fb95506e5 100644

--- a/content/public/common/connection_filter.h

+++ b/content/public/common/connection_filter.h

@@ -32,6 +32,9 @@ class CONTENT_EXPORT ConnectionFilter {

// If a ConnectionFilter is not interested in an incoming connection, it

// should return |false|.

+ //

+ // NOTE: This ConnectionFilter is NOT guaranteed to outlive |registry|, so you

+ // must not attach unsafe references to |this|, e.g., via AddInterface().

virtual bool OnConnect(const shell::Identity& remote_identity,

shell::InterfaceRegistry* registry,

shell::Connector* connector) = 0;