Issue 22686004: [NaCl SDK] Prune some unneeded parts of the PNaCl toolchain.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22686004: [NaCl SDK] Prune some unneeded parts of the PNaCl toolchain. (Closed)

Created:
7 years, 4 months ago by Sam Clegg

Modified:
7 years, 4 months ago

Reviewers:
Derek Schuff, eliben

CC:
chromium-reviews, binji

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[NaCl SDK] Prune some unneeded parts of the PNaCl toolchain. R=eliben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216794

Patch Set 1 #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	native_client_sdk/src/build_tools/build_sdk.py	View		2 chunks	+13 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

eliben

lgtm https://codereview.chromium.org/22686004/diff/1/native_client_sdk/src/build_tools/build_sdk.py File native_client_sdk/src/build_tools/build_sdk.py (right): https://codereview.chromium.org/22686004/diff/1/native_client_sdk/src/build_tools/build_sdk.py#newcode194 native_client_sdk/src/build_tools/build_sdk.py:194: # Currently we seem to rely on it ...

7 years, 4 months ago (2013-08-10 00:49:08 UTC) #2

Sam Clegg

7 years, 4 months ago (2013-08-10 01:07:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r216794 (presubmit successful).

Expand Messages | Collapse Messages