Issue 2268593002: DBC: Add back special case for float64 load/store

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2268593002: DBC: Add back special case for float64 load/store (Closed)

Created:
4 years, 4 months ago by zra

Modified:
4 years, 4 months ago

Reviewers:
Florian Schneider, rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

DBC: Add back special case for float64 load/store After my last change eliminating the special case, there was a 20% perf drop on FluidMotion. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/ae3d47fdc460f22432d7214c4c77589bf4028247

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -24 lines)			Patch
M	runtime/vm/constants_dbc.h	View		4 chunks	+13 lines, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language_dbc.cc	View		3 chunks	+24 lines, -20 lines	0 comments	Download
M	runtime/vm/simulator_dbc.cc	View	1	3 chunks	+35 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

zra

4 years, 4 months ago (2016-08-22 21:39:53 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
ae3d47fdc460f22432d7214c4c77589bf4028247 (presubmit successful).