Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 2268583002: Fix Ganesh analytic blurred rect draws (Closed)

Created:
4 years, 4 months ago by robertphillips
Modified:
4 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix Ganesh analytic blurred rect draws This CL does two things: It fixes the SkBlurMaskFilterImpl::directFilterRRectMaskGPU draw path to explicitly handle rects It fixes the SkGpuDevice::drawTextureProducerImpl draw path to provide the correct (src & device space) inputs to directFilterRRectMaskGPU. How this was working before was that GrRRectBlurEffect::Make would reject rect-rrects and the code would fallback to GrBlurUtils::drawPathWithMaskFilter which mapped the rect-rrect into device space correctly (of course, the rect-ness of the path was removed at that point so it was going through the slow path). GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2268583002 Committed: https://skia.googlesource.com/skia/+/6cfb10600250c5a67f0912694fd16719cf41ed51

Patch Set 1 #

Patch Set 2 : Clean up #

Patch Set 3 : update #

Patch Set 4 : Actually test the ignoreXform the correct way #

Patch Set 5 : update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -16 lines) Patch
M src/effects/SkBlurMaskFilter.cpp View 1 2 3 4 2 chunks +18 lines, -6 lines 0 comments Download
M src/gpu/SkGpuDevice_drawTexture.cpp View 1 chunk +16 lines, -10 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
robertphillips
4 years, 4 months ago (2016-08-22 15:06:16 UTC) #5
bsalomon
lgtm
4 years, 4 months ago (2016-08-22 16:06:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268583002/80001
4 years, 4 months ago (2016-08-22 23:12:53 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 23:13:51 UTC) #17
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/6cfb10600250c5a67f0912694fd16719cf41ed51

Powered by Google App Engine
This is Rietveld 408576698