Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: base/android/jni_weak_ref.h

Issue 2268553002: Small improvements to JNI references. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Learn about, and then fix, the most vexing parse. :) Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/android/jni_weak_ref.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_ANDROID_JNI_WEAK_REF_H_ 5 #ifndef BASE_ANDROID_JNI_WEAK_REF_H_
6 #define BASE_ANDROID_JNI_WEAK_REF_H_ 6 #define BASE_ANDROID_JNI_WEAK_REF_H_
7 7
8 #include <jni.h> 8 #include <jni.h>
9 9
10 #include "base/android/scoped_java_ref.h" 10 #include "base/android/scoped_java_ref.h"
11 #include "base/base_export.h" 11 #include "base/base_export.h"
12 12
13 // Manages WeakGlobalRef lifecycle. 13 // Manages WeakGlobalRef lifecycle.
14 // This class is not thread-safe w.r.t. get() and reset(). Multiple threads may 14 // This class is not thread-safe w.r.t. get() and reset(). Multiple threads may
15 // safely use get() concurrently, but if the user calls reset() (or of course, 15 // safely use get() concurrently, but if the user calls reset() (or of course,
16 // calls the destructor) they'll need to provide their own synchronization. 16 // calls the destructor) they'll need to provide their own synchronization.
17 class BASE_EXPORT JavaObjectWeakGlobalRef { 17 class BASE_EXPORT JavaObjectWeakGlobalRef {
18 public: 18 public:
19 JavaObjectWeakGlobalRef(); 19 JavaObjectWeakGlobalRef();
20 JavaObjectWeakGlobalRef(const JavaObjectWeakGlobalRef& orig); 20 JavaObjectWeakGlobalRef(const JavaObjectWeakGlobalRef& orig);
21 JavaObjectWeakGlobalRef(JavaObjectWeakGlobalRef&& orig);
21 JavaObjectWeakGlobalRef(JNIEnv* env, jobject obj); 22 JavaObjectWeakGlobalRef(JNIEnv* env, jobject obj);
23 JavaObjectWeakGlobalRef(JNIEnv* env,
24 const base::android::JavaRef<jobject>& obj);
22 virtual ~JavaObjectWeakGlobalRef(); 25 virtual ~JavaObjectWeakGlobalRef();
23 26
24 void operator=(const JavaObjectWeakGlobalRef& rhs); 27 void operator=(const JavaObjectWeakGlobalRef& rhs);
28 void operator=(JavaObjectWeakGlobalRef&& rhs);
25 29
26 base::android::ScopedJavaLocalRef<jobject> get(JNIEnv* env) const; 30 base::android::ScopedJavaLocalRef<jobject> get(JNIEnv* env) const;
27 31
28 bool is_empty() const { return obj_ == NULL; } 32 bool is_empty() const { return obj_ == nullptr; }
29 33
30 void reset(); 34 void reset();
31 35
32 private: 36 private:
33 void Assign(const JavaObjectWeakGlobalRef& rhs); 37 void Assign(const JavaObjectWeakGlobalRef& rhs);
34 38
35 jweak obj_; 39 jweak obj_;
36 }; 40 };
37 41
38 // Get the real object stored in the weak reference returned as a 42 // Get the real object stored in the weak reference returned as a
39 // ScopedJavaLocalRef. 43 // ScopedJavaLocalRef.
40 BASE_EXPORT base::android::ScopedJavaLocalRef<jobject> GetRealObject( 44 BASE_EXPORT base::android::ScopedJavaLocalRef<jobject> GetRealObject(
41 JNIEnv* env, jweak obj); 45 JNIEnv* env, jweak obj);
42 46
43 #endif // BASE_ANDROID_JNI_WEAK_REF_H_ 47 #endif // BASE_ANDROID_JNI_WEAK_REF_H_
OLDNEW
« no previous file with comments | « no previous file | base/android/jni_weak_ref.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698