Cleanup: Move ParseInfo to a separate file.

Cleanup: Move ParseInfo to a separate file.

This makes us able to get rid of dependencies to parser.h from places
which only need the ParseInfo, and also gets rid of the curious Parser
<-> Compiler circular dependency.

Also IWYUd where necessary.

BUG=

Committed: https://crrev.com/f9d60761156604843ecaa892e5733811f1be17a5
Cr-Commit-Position: refs/heads/master@{#38777}

[marja, 2016-08-22 09:24:35]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 09:24:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marja, 2016-08-22 09:30:00]

Description was changed from

==========
Cleanup: Move ParseInfo to a separate file.

This makes us able to get rid of dependencies to parser.h from places
which only need the ParseInfo, and also gets rid of the curious Parser
<-> Compiler circular dependency.

BUG=
==========

to

==========
Cleanup: Move ParseInfo to a separate file.

This makes us able to get rid of dependencies to parser.h from places
which only need the ParseInfo, and also gets rid of the curious Parser
<-> Compiler circular dependency.

Also IWYUd where necessary.

BUG=
==========

[marja, 2016-08-22 09:37:40]

marja@chromium.org changed reviewers:
+ verwaest@chromium.org

[marja, 2016-08-22 09:37:41]

verwaest, ptal

https://codereview.chromium.org/2268513002/diff/1/src/parsing/parse-info.cc
File src/parsing/parse-info.cc (right):

https://codereview.chromium.org/2268513002/diff/1/src/parsing/parse-info.cc#n...
src/parsing/parse-info.cc:75: ParseInfo::~ParseInfo() {
De-inlined

https://codereview.chromium.org/2268513002/diff/1/src/parsing/parse-info.cc#n...
src/parsing/parse-info.cc:83: DeclarationScope* ParseInfo::scope() const {
return literal()->scope(); }
De-inlined

https://codereview.chromium.org/2268513002/diff/1/src/parsing/parse-info.cc#n...
src/parsing/parse-info.cc:107: bool ParseInfo::script_is_native() const {
De-inlined

[Toon Verwaest, 2016-08-22 09:46:55]

lgtm
you'll need some additional owners I guess

[commit-bot: I haz the power, 2016-08-22 09:55:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 09:55:29]

Dry run: This issue passed the CQ dry run.

[marja, 2016-08-22 09:58:06]

marja@chromium.org changed reviewers:
+ titzer@chromium.org

[marja, 2016-08-22 09:58:07]

titzer@, could you review? You're the owner of the following:

  src/asmjs/asm-js.cc
  src/compiler/js-inlining.cc
  src/compiler/pipeline.cc
  src/wasm/wasm-js.cc
  test/cctest/asmjs/test-asm-typer.cc

Plus this CL kills a TODO(titzer) :)

[titzer, 2016-08-22 11:29:01]

On 2016/08/22 09:58:07, marja wrote:
> titzer@, could you review? You're the owner of the following:
> 
>   src/asmjs/asm-js.cc
>   src/compiler/js-inlining.cc
>   src/compiler/pipeline.cc
>   src/wasm/wasm-js.cc
>   test/cctest/asmjs/test-asm-typer.cc
> 
> Plus this CL kills a TODO(titzer) :)

LGTM. Nice!

[marja, 2016-08-22 11:31:22]

The CQ bit was checked by marja@chromium.org

[commit-bot: I haz the power, 2016-08-22 11:31:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 11:33:35]

Description was changed from

==========
Cleanup: Move ParseInfo to a separate file.

This makes us able to get rid of dependencies to parser.h from places
which only need the ParseInfo, and also gets rid of the curious Parser
<-> Compiler circular dependency.

Also IWYUd where necessary.

BUG=
==========

to

==========
Cleanup: Move ParseInfo to a separate file.

This makes us able to get rid of dependencies to parser.h from places
which only need the ParseInfo, and also gets rid of the curious Parser
<-> Compiler circular dependency.

Also IWYUd where necessary.

BUG=
==========

[commit-bot: I haz the power, 2016-08-22 11:33:36]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-22 11:34:04]

Description was changed from

==========
Cleanup: Move ParseInfo to a separate file.

This makes us able to get rid of dependencies to parser.h from places
which only need the ParseInfo, and also gets rid of the curious Parser
<-> Compiler circular dependency.

Also IWYUd where necessary.

BUG=
==========

to

==========
Cleanup: Move ParseInfo to a separate file.

This makes us able to get rid of dependencies to parser.h from places
which only need the ParseInfo, and also gets rid of the curious Parser
<-> Compiler circular dependency.

Also IWYUd where necessary.

BUG=

Committed: https://crrev.com/f9d60761156604843ecaa892e5733811f1be17a5
Cr-Commit-Position: refs/heads/master@{#38777}
==========

[commit-bot: I haz the power, 2016-08-22 11:34:05]

Patchset 1 (id:??) landed as
https://crrev.com/f9d60761156604843ecaa892e5733811f1be17a5
Cr-Commit-Position: refs/heads/master@{#38777}