Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Unified Diff: runtime/vm/object.h

Issue 22685007: Implement updated method overriding rules in the vm. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.h
===================================================================
--- runtime/vm/object.h (revision 26025)
+++ runtime/vm/object.h (working copy)
@@ -939,7 +939,9 @@
void Finalize() const;
- const char* ApplyPatch(const Class& patch) const;
+ // Apply given patch class to this class.
+ // Return true on success, or false and error otherwise.
+ bool ApplyPatch(const Class& patch, Error* error) const;
RawError* EnsureIsFinalized(Isolate* isolate) const;
@@ -1662,8 +1664,9 @@
// Returns true if this function has parameters that are compatible with the
// parameters of the other function in order for this function to override the
- // other function. Parameter types are ignored.
- bool HasCompatibleParametersWith(const Function& other) const;
+ // other function.
+ bool HasCompatibleParametersWith(const Function& other,
+ Error* malformed_error) const;
// Returns true if the type of this function is a subtype of the type of
// the other function.
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698