Implement updated method overriding rules in the vm.

Implement updated method overriding rules in the vm (issue 11495).
Introduce --error-on-bad-override flag and use it when generating snapshots.
Fix signature checking when patching methods.
Fix errors in patch files.
Fix receiver type of constructors.
Fix finalization of mixin application typedefs.
Update tests and status files.

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26027

[siva, 2013-08-12 02:56:42]

lgtm

https://codereview.chromium.org/22685007/diff/9001/runtime/lib/date_patch.dart
File runtime/lib/date_patch.dart (right):

https://codereview.chromium.org/22685007/diff/9001/runtime/lib/date_patch.dar...
runtime/lib/date_patch.dart:221: return null;
should this now return 0 or -1 and not null?

https://codereview.chromium.org/22685007/diff/9001/runtime/lib/date_patch.dar...
runtime/lib/date_patch.dart:234: return null;
ditto comment here.

https://codereview.chromium.org/22685007/diff/9001/runtime/vm/class_finalizer.cc
File runtime/vm/class_finalizer.cc (right):

https://codereview.chromium.org/22685007/diff/9001/runtime/vm/class_finalizer...
runtime/vm/class_finalizer.cc:1645: (Array::Handle(cls.functions()).Length() ==
0)) {
could be written as:

if (cls.is_synthesized_class() &&
    (cls.functions() == Object::empty_array().raw()) {

https://codereview.chromium.org/22685007/diff/9001/runtime/vm/class_finalizer...
runtime/vm/class_finalizer.cc:1893: if
(Class::Handle(super_type.type_class()).IsSignatureClass()) {
Why not move the assignment 
interface_class = super_type.type_class();
ahead of this 'if check' and write the if check as
if (interface_class.IsSignatureClass()) {

https://codereview.chromium.org/22685007/diff/9001/runtime/vm/class_finalizer.h
File runtime/vm/class_finalizer.h (right):

https://codereview.chromium.org/22685007/diff/9001/runtime/vm/class_finalizer...
runtime/vm/class_finalizer.h:79: // Finalize the types appearing in the
declaration of class cls, i.e. its
class 'cls',

https://codereview.chromium.org/22685007/diff/9001/runtime/vm/dart_api_impl_t...
File runtime/vm/dart_api_impl_test.cc (right):

https://codereview.chromium.org/22685007/diff/9001/runtime/vm/dart_api_impl_t...
runtime/vm/dart_api_impl_test.cc:5314: "  /*patch*/ method(var value) {\n"
void method(var value) {....

https://codereview.chromium.org/22685007/diff/9001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/22685007/diff/9001/runtime/vm/parser.cc#newco...
runtime/vm/parser.cc:6936: Isolate::Current()->long_jump_base()->Jump(1, error);
Why Isolate:Current() and not the cached isolate?

https://codereview.chromium.org/22685007/diff/9001/tests/co19/co19-runtime.st...
File tests/co19/co19-runtime.status (right):

https://codereview.chromium.org/22685007/diff/9001/tests/co19/co19-runtime.st...
tests/co19/co19-runtime.status:391:
Language/07_Classes/1_Instance_Methods_A01_t01: Fail # Override rules have been
relaxed. Issue
Missing issue number here and below?

[regis, 2013-08-12 17:45:27]

Thanks!

https://codereview.chromium.org/22685007/diff/9001/runtime/lib/date_patch.dart
File runtime/lib/date_patch.dart (right):

https://codereview.chromium.org/22685007/diff/9001/runtime/lib/date_patch.dar...
runtime/lib/date_patch.dart:221: return null;
On 2013/08/12 02:56:43, siva wrote:
> should this now return 0 or -1 and not null?

null is actually a valid value to return to indicate an error. I see the caller
checking for null in the core lib.

https://codereview.chromium.org/22685007/diff/9001/runtime/lib/date_patch.dar...
runtime/lib/date_patch.dart:234: return null;
On 2013/08/12 02:56:43, siva wrote:
> ditto comment here.

ditto

https://codereview.chromium.org/22685007/diff/9001/runtime/vm/class_finalizer.cc
File runtime/vm/class_finalizer.cc (right):

https://codereview.chromium.org/22685007/diff/9001/runtime/vm/class_finalizer...
runtime/vm/class_finalizer.cc:1645: (Array::Handle(cls.functions()).Length() ==
0)) {
On 2013/08/12 02:56:43, siva wrote:
> could be written as:
> 
> if (cls.is_synthesized_class() &&
>     (cls.functions() == Object::empty_array().raw()) {

Done.

https://codereview.chromium.org/22685007/diff/9001/runtime/vm/class_finalizer...
runtime/vm/class_finalizer.cc:1893: if
(Class::Handle(super_type.type_class()).IsSignatureClass()) {
On 2013/08/12 02:56:43, siva wrote:
> Why not move the assignment 
> interface_class = super_type.type_class();
> ahead of this 'if check' and write the if check as
> if (interface_class.IsSignatureClass()) {

Done.

https://codereview.chromium.org/22685007/diff/9001/runtime/vm/class_finalizer.h
File runtime/vm/class_finalizer.h (right):

https://codereview.chromium.org/22685007/diff/9001/runtime/vm/class_finalizer...
runtime/vm/class_finalizer.h:79: // Finalize the types appearing in the
declaration of class cls, i.e. its
On 2013/08/12 02:56:43, siva wrote:
> class 'cls',

Done.

https://codereview.chromium.org/22685007/diff/9001/runtime/vm/dart_api_impl_t...
File runtime/vm/dart_api_impl_test.cc (right):

https://codereview.chromium.org/22685007/diff/9001/runtime/vm/dart_api_impl_t...
runtime/vm/dart_api_impl_test.cc:5314: "  /*patch*/ method(var value) {\n"
On 2013/08/12 02:56:43, siva wrote:
> void method(var value) {....

Done.

https://codereview.chromium.org/22685007/diff/9001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/22685007/diff/9001/runtime/vm/parser.cc#newco...
runtime/vm/parser.cc:6936: Isolate::Current()->long_jump_base()->Jump(1, error);
On 2013/08/12 02:56:43, siva wrote:
> Why Isolate:Current() and not the cached isolate?

This function is now static.

https://codereview.chromium.org/22685007/diff/9001/tests/co19/co19-runtime.st...
File tests/co19/co19-runtime.status (right):

https://codereview.chromium.org/22685007/diff/9001/tests/co19/co19-runtime.st...
tests/co19/co19-runtime.status:391:
Language/07_Classes/1_Instance_Methods_A01_t01: Fail # Override rules have been
relaxed. Issue
On 2013/08/12 02:56:43, siva wrote:
> Missing issue number here and below?

Filed co19 issue 485 and added reference here.

[regis, 2013-08-12 20:29:05]

Committed patchset #4 manually as r26027 (presubmit successful).