Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2538)

Unified Diff: chrome/browser/ui/webui/inspect_ui.cc

Issue 22685003: Visualize status of port forwarding sockets in chrome:inspect Devices tab (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/inspect/inspect.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/inspect_ui.cc
diff --git a/chrome/browser/ui/webui/inspect_ui.cc b/chrome/browser/ui/webui/inspect_ui.cc
index ad6488b6aceb29eb622708f68fd0db2a0408a6a8..430be77937c97970fcbf52d442f89b785cd8df1c 100644
--- a/chrome/browser/ui/webui/inspect_ui.cc
+++ b/chrome/browser/ui/webui/inspect_ui.cc
@@ -96,6 +96,7 @@ static const char kAdbBrowserNameField[] = "adbBrowserName";
static const char kAdbGlobalIdField[] = "adbGlobalId";
static const char kAdbBrowsersField[] = "browsers";
static const char kAdbPagesField[] = "pages";
+static const char kAdbPortStatus[] = "adbPortStatus";
DictionaryValue* BuildTargetDescriptor(
const std::string& target_type,
@@ -624,6 +625,17 @@ void InspectUI::RemoteDevicesChanged(
}
browser_list->Append(browser_data);
}
+
+ DictionaryValue* port_status_dict = new DictionaryValue();
+ typedef DevToolsAdbBridge::RemoteDevice::PortStatusMap StatusMap;
+ const StatusMap& port_status = device->port_status();
+ for (StatusMap::const_iterator it = port_status.begin();
+ it != port_status.end(); ++it) {
+ port_status_dict->SetInteger(
+ base::StringPrintf("%d", it->first), it->second);
+ }
+ device_data->Set(kAdbPortStatus, port_status_dict);
+
device_list.Append(device_data);
}
web_ui()->CallJavascriptFunction("populateDeviceLists", device_list);
« no previous file with comments | « chrome/browser/resources/inspect/inspect.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698