Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4191)

Unified Diff: chrome/browser/devtools/devtools_protocol.cc

Issue 22685003: Visualize status of port forwarding sockets in chrome:inspect Devices tab (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/devtools_protocol.h ('k') | chrome/browser/devtools/tethering_adb_filter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_protocol.cc
diff --git a/chrome/browser/devtools/devtools_protocol.cc b/chrome/browser/devtools/devtools_protocol.cc
index eed5940b627c915ecdd48543f1965dcb695a9574..922f9e913e0c068e2ec2eb855e88b6ed8495aeed 100644
--- a/chrome/browser/devtools/devtools_protocol.cc
+++ b/chrome/browser/devtools/devtools_protocol.cc
@@ -11,6 +11,8 @@ namespace {
const char kIdParam[] = "id";
const char kMethodParam[] = "method";
const char kParamsParam[] = "params";
+const char kErrorParam[] = "error";
+const char kErrorCodeParam[] = "code";
} // namespace
DevToolsProtocol::Message::~Message() {
@@ -52,6 +54,14 @@ DevToolsProtocol::Notification::Notification(const std::string& method,
: Message(method, params) {
}
+DevToolsProtocol::Response::~Response() {
+}
+
+DevToolsProtocol::Response::Response(int id, int error_code)
+ : id_(id),
+ error_code_(error_code) {
+}
+
// static
DevToolsProtocol::Notification* DevToolsProtocol::ParseNotification(
const std::string& json) {
@@ -70,3 +80,23 @@ DevToolsProtocol::Notification* DevToolsProtocol::ParseNotification(
dict->GetDictionary(kParamsParam, &params);
return new Notification(method, params);
}
+
+DevToolsProtocol::Response* DevToolsProtocol::ParseResponse(
+ const std::string& json) {
+ scoped_ptr<base::Value> value(base::JSONReader::Read(json));
+ if (!value || !value->IsType(Value::TYPE_DICTIONARY))
+ return NULL;
+
+ scoped_ptr<base::DictionaryValue> dict(
+ static_cast<base::DictionaryValue*>(value.release()));
+
+ int id;
+ if (!dict->GetInteger(kIdParam, &id))
+ return NULL;
+
+ int error_code = 0;
+ base::DictionaryValue* error_dict = NULL;
+ if (dict->GetDictionary(kErrorParam, &error_dict))
+ error_dict->GetInteger(kErrorCodeParam, &error_code);
+ return new Response(id, error_code);
+}
« no previous file with comments | « chrome/browser/devtools/devtools_protocol.h ('k') | chrome/browser/devtools/tethering_adb_filter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698