Chromium Code Reviews| Index: chrome/browser/devtools/devtools_protocol.h |
| diff --git a/chrome/browser/devtools/devtools_protocol.h b/chrome/browser/devtools/devtools_protocol.h |
| index 9a01eee531373b65e21b95d311a9e20905a2a55a..c781858c15b0c7b7e84f98cd9985f7699ac5842e 100644 |
| --- a/chrome/browser/devtools/devtools_protocol.h |
| +++ b/chrome/browser/devtools/devtools_protocol.h |
| @@ -38,7 +38,7 @@ class DevToolsProtocol { |
| public: |
| // Takes ownership of |params|. |
| Command(int id, const std::string& method, base::DictionaryValue* params); |
| - virtual ~Command(); |
| + virtual ~Command(); |
| int id() { return id_; } |
| std::string Serialize(); |
| @@ -49,6 +49,23 @@ class DevToolsProtocol { |
| DISALLOW_COPY_AND_ASSIGN(Command); |
| }; |
| + class Response { |
| + public: |
| + virtual ~Response(); |
| + |
| + int id() { return id_; } |
| + int error_code() { return error_code_; } |
| + |
| + private: |
| + friend class DevToolsProtocol; |
| + |
| + Response(int id, int error_code); |
| + int id_; |
| + int error_code_; |
| + |
| + DISALLOW_COPY_AND_ASSIGN(Response); |
| + }; |
| + |
| class Notification : public Message { |
| public: |
| virtual ~Notification(); |
| @@ -65,6 +82,8 @@ class DevToolsProtocol { |
| static Notification* ParseNotification(const std::string& json); |
| + static Response* ParseResponse(const std::string& json); |
|
pfeldman
2013/08/08 16:43:22
Please add comment suggesting that ownership is pa
Vladislav Kaznacheev
2013/08/09 08:24:58
On 2013/08/08 16:43:22, pfeldman wrote:
> Please a
|
| + |
| private: |
| DevToolsProtocol() {} |